* [PATCH] wcn36xx: set self sta entry as HT capable
@ 2013-11-19 14:13 Chun-Yeow Yeoh
2013-11-20 7:17 ` Eugene Krasnikov
0 siblings, 1 reply; 6+ messages in thread
From: Chun-Yeow Yeoh @ 2013-11-19 14:13 UTC (permalink / raw)
To: linux-wireless; +Cc: k.eugene.e, linville, wcn36xx, Chun-Yeow Yeoh
Set the HT capable for self STA entry for bss configuration. Otherwise,
only legacy rate will be used for transmitting, especially for mesh
mode.
Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
---
drivers/net/wireless/ath/wcn36xx/smd.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 19f43de..5160b04 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -115,6 +115,13 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta,
}
}
+static void wcn36xx_smd_set_sta_default_ht_params(
+ struct wcn36xx_hal_config_sta_params *sta_params)
+{
+ wcn36xx_set_default_rates(&sta_params->supported_rates);
+ sta_params->ht_capable = 1;
+}
+
static void wcn36xx_smd_set_sta_params(struct wcn36xx *wcn,
struct ieee80211_vif *vif,
struct ieee80211_sta *sta,
@@ -171,7 +178,7 @@ static void wcn36xx_smd_set_sta_params(struct wcn36xx *wcn,
memcpy(&sta_params->supported_rates, &priv_sta->supported_rates,
sizeof(priv_sta->supported_rates));
} else {
- wcn36xx_set_default_rates(&sta_params->supported_rates);
+ wcn36xx_smd_set_sta_default_ht_params(sta_params);
}
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: set self sta entry as HT capable
2013-11-19 14:13 [PATCH] wcn36xx: set self sta entry as HT capable Chun-Yeow Yeoh
@ 2013-11-20 7:17 ` Eugene Krasnikov
2013-11-20 7:26 ` Yeoh Chun-Yeow
0 siblings, 1 reply; 6+ messages in thread
From: Eugene Krasnikov @ 2013-11-20 7:17 UTC (permalink / raw)
To: Chun-Yeow Yeoh; +Cc: linux-wireless, John Linville, wcn36xx
Why would the function that is setting default HT params will also set
default rates? There is no connection between HT params and default
rates.
But the idea to set HT by default in AP mode is something that we
definitely need.
On Tue, Nov 19, 2013 at 2:13 PM, Chun-Yeow Yeoh <yeohchunyeow@gmail.com> wrote:
> Set the HT capable for self STA entry for bss configuration. Otherwise,
> only legacy rate will be used for transmitting, especially for mesh
> mode.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
> ---
> drivers/net/wireless/ath/wcn36xx/smd.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 19f43de..5160b04 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
> @@ -115,6 +115,13 @@ static void wcn36xx_smd_set_sta_ht_params(struct ieee80211_sta *sta,
> }
> }
>
> +static void wcn36xx_smd_set_sta_default_ht_params(
> + struct wcn36xx_hal_config_sta_params *sta_params)
> +{
> + wcn36xx_set_default_rates(&sta_params->supported_rates);
> + sta_params->ht_capable = 1;
> +}
> +
> static void wcn36xx_smd_set_sta_params(struct wcn36xx *wcn,
> struct ieee80211_vif *vif,
> struct ieee80211_sta *sta,
> @@ -171,7 +178,7 @@ static void wcn36xx_smd_set_sta_params(struct wcn36xx *wcn,
> memcpy(&sta_params->supported_rates, &priv_sta->supported_rates,
> sizeof(priv_sta->supported_rates));
> } else {
> - wcn36xx_set_default_rates(&sta_params->supported_rates);
> + wcn36xx_smd_set_sta_default_ht_params(sta_params);
> }
> }
>
> --
> 1.7.9.5
>
--
Best regards,
Eugene
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: set self sta entry as HT capable
2013-11-20 7:17 ` Eugene Krasnikov
@ 2013-11-20 7:26 ` Yeoh Chun-Yeow
2013-11-20 7:40 ` Eugene Krasnikov
0 siblings, 1 reply; 6+ messages in thread
From: Yeoh Chun-Yeow @ 2013-11-20 7:26 UTC (permalink / raw)
To: Eugene Krasnikov; +Cc: linux-wireless, John Linville, wcn36xx
Hi, Eugene
> Why would the function that is setting default HT params will also set
> default rates? There is no connection between HT params and default
> rates.
How about rename the function name to wcn36xx_smd_set_self_sta?
----
Chun-Yeow
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: set self sta entry as HT capable
2013-11-20 7:26 ` Yeoh Chun-Yeow
@ 2013-11-20 7:40 ` Eugene Krasnikov
[not found] ` <CAEFj9859MXVE5L1Diiw0cNsaNPaNEYPddm0Fjco5hJGJpLtNSA@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Eugene Krasnikov @ 2013-11-20 7:40 UTC (permalink / raw)
To: Yeoh Chun-Yeow; +Cc: linux-wireless, John Linville, wcn36xx
How about wcn36xx_smd_set_sta_default_ht_params?
This function will set all of the following fields to default values:
sta_params->ht_capable
sta_params->tx_channel_width_set
sta_params->lsig_txop_protection
sta_params->max_ampdu_size
sta_params->max_ampdu_density
sta_params->max_amsdu_size
sta_params->sgi_20Mhz
sta_params->sgi_40mhz
sta_params->green_field_capable
sta_params->delayed_ba_support
sta_params->dsss_cck_mode_40mhz
And then in wcn36xx_smd_set_sta_params it is called like this:
wcn36xx_set_default_rates(&sta_params->supported_rates);
wcn36xx_smd_set_sta_default_ht_params
How does that sound?
On Wed, Nov 20, 2013 at 7:26 AM, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote:
> Hi, Eugene
>
>> Why would the function that is setting default HT params will also set
>> default rates? There is no connection between HT params and default
>> rates.
> How about rename the function name to wcn36xx_smd_set_self_sta?
>
> ----
> Chun-Yeow
--
Best regards,
Eugene
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: set self sta entry as HT capable
[not found] ` <CAEFj9859MXVE5L1Diiw0cNsaNPaNEYPddm0Fjco5hJGJpLtNSA@mail.gmail.com>
@ 2013-11-20 7:55 ` Eugene Krasnikov
2013-11-20 8:05 ` Yeoh Chun-Yeow
0 siblings, 1 reply; 6+ messages in thread
From: Eugene Krasnikov @ 2013-11-20 7:55 UTC (permalink / raw)
To: Yeoh Chun-Yeow; +Cc: linux-wireless, John Linville, wcn36xx
Most of these values are taken from wcn_band_2ghz
Will try to remember:
sta_params->ht_capable = 1
sta_params->tx_channel_width_set = 1
sta_params->lsig_txop_protection = 1
sta_params->max_ampdu_size = 3 // Might be wrong but let's have this
value as a begining.
sta_params->max_ampdu_density = 5 // Might be wrong but let's have
this value as a begining.
sta_params->max_amsdu_size = 0
sta_params->sgi_20Mhz = 1
sta_params->sgi_40mhz = 1
sta_params->green_field_capable = 1
sta_params->delayed_ba_support = 0
sta_params->dsss_cck_mode_40mhz = 1
On Wed, Nov 20, 2013 at 7:43 AM, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote:
>> This function will set all of the following fields to default values:
>> sta_params->ht_capable
>> sta_params->tx_channel_width_set
>> sta_params->lsig_txop_protection
>> sta_params->max_ampdu_size
>> sta_params->max_ampdu_density
>> sta_params->max_amsdu_size
>> sta_params->sgi_20Mhz
>> sta_params->sgi_40mhz
>> sta_params->green_field_capable
>> sta_params->delayed_ba_support
>> sta_params->dsss_cck_mode_40mhz
>
>
> I am alright with that. But I am not sure about the default value of other
> fields mentioned above. Are you able to provide that?
>
>>
>> And then in wcn36xx_smd_set_sta_params it is called like this:
>> wcn36xx_set_default_rates(&sta_params->supported_rates);
>> wcn36xx_smd_set_sta_default_ht_params
>>
>> How does that sound?
>
>
> ---
> Chun-Yeow
--
Best regards,
Eugene
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: set self sta entry as HT capable
2013-11-20 7:55 ` Eugene Krasnikov
@ 2013-11-20 8:05 ` Yeoh Chun-Yeow
0 siblings, 0 replies; 6+ messages in thread
From: Yeoh Chun-Yeow @ 2013-11-20 8:05 UTC (permalink / raw)
To: Eugene Krasnikov; +Cc: linux-wireless, John Linville, wcn36xx
Alright, I will resubmit the patch with these as default value.
---
Chun-Yeow
On Wed, Nov 20, 2013 at 3:55 PM, Eugene Krasnikov <k.eugene.e@gmail.com> wrote:
> Most of these values are taken from wcn_band_2ghz
>
> Will try to remember:
>
> sta_params->ht_capable = 1
> sta_params->tx_channel_width_set = 1
> sta_params->lsig_txop_protection = 1
> sta_params->max_ampdu_size = 3 // Might be wrong but let's have this
> value as a begining.
> sta_params->max_ampdu_density = 5 // Might be wrong but let's have
> this value as a begining.
> sta_params->max_amsdu_size = 0
> sta_params->sgi_20Mhz = 1
> sta_params->sgi_40mhz = 1
> sta_params->green_field_capable = 1
> sta_params->delayed_ba_support = 0
> sta_params->dsss_cck_mode_40mhz = 1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-20 8:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-19 14:13 [PATCH] wcn36xx: set self sta entry as HT capable Chun-Yeow Yeoh
2013-11-20 7:17 ` Eugene Krasnikov
2013-11-20 7:26 ` Yeoh Chun-Yeow
2013-11-20 7:40 ` Eugene Krasnikov
[not found] ` <CAEFj9859MXVE5L1Diiw0cNsaNPaNEYPddm0Fjco5hJGJpLtNSA@mail.gmail.com>
2013-11-20 7:55 ` Eugene Krasnikov
2013-11-20 8:05 ` Yeoh Chun-Yeow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).