From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org, Jouni Malinen <jouni@qca.qualcomm.com>
Subject: Re: [RFC] wireless, ipv4, ipv6: drop GTK-protected unicast IP packets
Date: Thu, 21 Nov 2013 14:08:27 +0100 [thread overview]
Message-ID: <1385039307.14273.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1385039154-20637-1-git-send-email-johannes@sipsolutions.net> (sfid-20131121_140611_855342_F7C001E6)
On Thu, 2013-11-21 at 14:05 +0100, Johannes Berg wrote:
> @@ -498,7 +500,8 @@ struct sk_buff {
> * headers if needed
> */
> __u8 encapsulation:1;
> - /* 7/9 bit hole (depending on ndisc_nodetype presence) */
> + __u8 drop_unicast:1;
The obvious question is here, and for IPv4/IPv6 - should the wireless
stack be responsible for doing this instead?
The upside of this approach as-is is that all other protocols can easily
be extended to do this and no protocol-specific code is needed in
wireless; the downside is that it clobbers all protocol code. Thoughts?
johannes
next prev parent reply other threads:[~2013-11-21 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 13:05 [RFC] wireless, ipv4, ipv6: drop GTK-protected unicast IP packets Johannes Berg
2013-11-21 13:08 ` Johannes Berg [this message]
2013-11-21 14:24 ` Eric Dumazet
2013-11-21 14:31 ` Johannes Berg
2013-11-21 19:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385039307.14273.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).