linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCH 0/4] Fix CSA locking issues
Date: Thu, 21 Nov 2013 16:56:19 +0100	[thread overview]
Message-ID: <1385049383-5617-1-git-send-email-sw@simonwunderlich.de> (raw)

Unfortunately my channel switch announcement patches contained locking issues
which I didn't notice during my test due to bad configuration. Johannes pointed
them out, so here is my attempt to fix them. This series attempts to fix two
issues:

 * There are "suspicious rcu_dereference_protected() usage" problems for
   ieee80211_assign_beacon and ieee80211_ibss_csa_beacon because the respective
   locking was missing
 * There is a circular dependency between the wdev/sdata-lock and the
   csa_finalize worker lock (see description in patch 3).

These patches contain changes for issues in the RFC series pointed out by
Johannes. I've also found another possible leak so I added this to the series.
Patches are based on mac80211-next.

Cheers,
   Simon

Simon Wunderlich (4):
  cfg80211/mac80211: modify beacon using sdata/wdev-lock, not rtnl lock
  cfg80211/mac80211/ath6kl: acquire wdev lock outside ch_switch_notify
  mac80211: don't cancel csa finalize work within stop_ap
  mac80211: don't leak next beacon when csa is aborted

 drivers/net/wireless/ath/ath6kl/cfg80211.c |    2 ++
 include/net/cfg80211.h                     |    3 +-
 net/mac80211/cfg.c                         |   47 +++++++++++++++++++---------
 net/mac80211/ieee80211_i.h                 |    3 ++
 net/mac80211/iface.c                       |    7 ++++-
 net/wireless/nl80211.c                     |   31 ++++++++++++------
 6 files changed, 67 insertions(+), 26 deletions(-)

-- 
1.7.10.4


             reply	other threads:[~2013-11-21 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21 15:56 Simon Wunderlich [this message]
2013-11-21 15:56 ` [PATCH 1/4] cfg80211/mac80211: modify beacon using sdata/wdev-lock, not rtnl lock Simon Wunderlich
2013-11-21 15:56 ` [PATCH 2/4] cfg80211/mac80211/ath6kl: acquire wdev lock outside ch_switch_notify Simon Wunderlich
2013-11-21 15:56 ` [PATCH 3/4] mac80211: don't cancel csa finalize work within stop_ap Simon Wunderlich
2013-11-21 15:56 ` [PATCH 4/4] mac80211: don't leak next beacon when csa is aborted Simon Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385049383-5617-1-git-send-email-sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).