From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 4/4] cfg80211: DFS use 10 minutes CAC when weather channels
Date: Mon, 25 Nov 2013 17:44:38 +0100 [thread overview]
Message-ID: <1385397878.4443.56.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1384940517-6154-4-git-send-email-janusz.dziedzic@tieto.com> (sfid-20131120_104224_778593_81B2F202)
On Wed, 2013-11-20 at 10:41 +0100, Janusz Dziedzic wrote:
> + r = cfg80211_get_chans_dfs_is_weather(wiphy,
> + chandef->center_freq1,
> + width);
> +
> + if (r)
> + return r;
extra blank line
> + default:
> + WARN_ON(chandef->center_freq2);
> + break;
seems you'd want to return an error here
johannes
next prev parent reply other threads:[~2013-11-25 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 9:41 [PATCH v2 1/4] cfg80211: add reg_get_dfs_region() Janusz Dziedzic
2013-11-20 9:41 ` [PATCH v2 2/4] cfg80211: DFS check dfs_region before usage Janusz Dziedzic
2013-11-20 9:41 ` [PATCH v2 3/4] cfg80211/mac80211: DFS pass CAC time as a parameter Janusz Dziedzic
2013-11-20 9:41 ` [PATCH v2 4/4] cfg80211: DFS use 10 minutes CAC when weather channels Janusz Dziedzic
2013-11-20 9:49 ` Janusz Dziedzic
2013-11-25 16:43 ` Johannes Berg
2013-11-25 16:44 ` Johannes Berg [this message]
2013-11-25 16:39 ` [PATCH v2 1/4] cfg80211: add reg_get_dfs_region() Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385397878.4443.56.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox