From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k@lists.infradead.org,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] ath10k: use nss provided by mac80211
Date: Fri, 29 Nov 2013 16:37:14 +0100 [thread overview]
Message-ID: <1385739434.8656.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQmtkBGpktbLRfmiLuLDKP9TnUeWu4OMeGUsVcq7m05u4Q@mail.gmail.com> (sfid-20131127_112551_029392_CB0E2653)
On Wed, 2013-11-27 at 11:25 +0100, Michal Kazior wrote:
> On 26 November 2013 14:57, Michal Kazior <michal.kazior@tieto.com> wrote:
> > Calculating STA NSS just from the mcs rateset is
> > not the greatest idea.
> >
> > This should prevent connectivity issues if
> > mac80211 is ever to set rx_nss to something other
> > rather than base on max mcs map. As an example
> > operation mode change notification in assoc
> > request may change rx_nss initial values in the
> > future.
> >
> > Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> > ---
>
> Drop this single patch, please.
>
> I just noticed rx_nss doesn't seem to have correct value when associating..
FWIW, there are pending changes to make the opmode data come from
hostapd to mac80211 so that this would be set correctly when the station
is associating.
Or where did you find it wasn't set correctly?
johannes
next prev parent reply other threads:[~2013-11-29 15:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 13:26 [PATCH 0/3] ath10k: fixes 2013-11-22 Michal Kazior
2013-11-22 13:26 ` [PATCH 1/3] ath10k: use nss provided by mac80211 Michal Kazior
2013-11-24 13:50 ` Kalle Valo
2013-11-25 10:11 ` Michal Kazior
2013-11-22 13:26 ` [PATCH 2/3] ath10k: implement sta_rc_update() Michal Kazior
2013-11-22 13:26 ` [PATCH 3/3] ath10k: fix Tx status clearing Michal Kazior
2013-11-24 13:51 ` Kalle Valo
2013-11-26 13:57 ` [PATCH v2 0/3] ath10k: fixes 2013-11-22 Michal Kazior
2013-11-26 13:57 ` [PATCH v2 1/3] ath10k: use nss provided by mac80211 Michal Kazior
2013-11-27 10:25 ` Michal Kazior
2013-11-27 14:55 ` Kalle Valo
2013-11-29 15:37 ` Johannes Berg [this message]
2013-12-02 10:54 ` [RFC] mac80211: fix rx_nss calculation for drivers with hw rc Michal Kazior
2013-12-02 10:59 ` Johannes Berg
2013-12-02 14:42 ` Johannes Berg
2013-11-26 13:57 ` [PATCH v2 2/3] ath10k: implement sta_rc_update() Michal Kazior
2013-11-27 15:03 ` Kalle Valo
2013-12-18 10:11 ` [PATCH v2] " Michal Kazior
2013-12-20 10:21 ` Kalle Valo
2013-12-20 13:56 ` Ben Greear
2013-11-26 13:57 ` [PATCH v2 3/3] ath10k: fix Tx status clearing Michal Kazior
2013-11-27 15:04 ` [PATCH v2 0/3] ath10k: fixes 2013-11-22 Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385739434.8656.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).