public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, j@w1.fi
Subject: Re: [RFC] cfg80211/mac80211: drop GTK-protected unicast IP packets
Date: Tue, 03 Dec 2013 10:34:25 +0100	[thread overview]
Message-ID: <1386063265.4393.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CABPxzYJfBG0YtCrfkg_PqV4MP+MdLePhD2QdFQF9D+EfPObnZQ@mail.gmail.com> (sfid-20131203_102026_263382_A70E781F)

On Tue, 2013-12-03 at 14:50 +0530, Krishna Chaitanya wrote:
> On Tue, Dec 3, 2013 at 12:21 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > The GTK is shared by all stations in an 802.11 BSS and as such any
> > one of them can send forged group-addressed frames. To prevent this
> > kind of attack, drop unicast IP packets if they were protected with
> > the GTK, i.e. were multicast packets at the 802.11 layer.
> >
> > Based in part on a patch by Jouni that did the same but in the IP
> > stack, which was considered too intrusive.
> >
> As per RFC 1122 this is an invalid case:
>          When a host sends a datagram to a link-layer broadcast address,
>          the IP destination address MUST be a legal IP broadcast or IP
>          multicast address.
> 
>          A host SHOULD silently discard a datagram that is received via
>          a link-layer broadcast (see Section 2.4) but does not specify
>          an IP multicast or broadcast destination address.
> 
> We can simply drop this frame irrespective of GTK/PTK is used.

Interesting. Can you point out where this is implemented in the IP
stack(s)?

johannes


  reply	other threads:[~2013-12-03  9:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 18:51 [RFC] cfg80211/mac80211: drop GTK-protected unicast IP packets Johannes Berg
2013-12-03  8:52 ` Pontus Fuchs
2013-12-03  8:54   ` Johannes Berg
2013-12-03  9:20 ` Krishna Chaitanya
2013-12-03  9:34   ` Johannes Berg [this message]
2013-12-03 11:16     ` Krishna Chaitanya
2013-12-03  9:44 ` Nicolas Cavallari
2013-12-03  9:45   ` Johannes Berg
2013-12-03 10:41     ` Nicolas Cavallari
2013-12-03 10:43       ` Nicolas Cavallari
2013-12-03 10:48       ` Johannes Berg
2013-12-03 10:51         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386063265.4393.3.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=chaitanya.mgit@gmail.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox