From: Johannes Berg <johannes@sipsolutions.net>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Karl Beldan <karl.beldan@rivierawaves.com>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>,
Andrei Otcheretianski <andrei.otcheretianski@intel.com>
Subject: Re: [PATCH v4] mac80211_hwsim: claim CSA support for AP
Date: Tue, 03 Dec 2013 13:55:33 +0100 [thread overview]
Message-ID: <1386075333.4393.13.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1385224698-12294-1-git-send-email-karl.beldan@gmail.com> (sfid-20131123_173902_687822_1D76D641)
On Sat, 2013-11-23 at 17:38 +0100, Karl Beldan wrote:
> This adds a per vif bool csa_finished that is set after a call to
> ieee80211_csa_finish() and used to skip beaconing while csa_active is
> set in case a beacon is scheduled prior to csa_finalize_work completion.
> This bool and the number of beacons transmitted during the CSA up to the
> call to ieee80211_csa_finish() are reset in channel_switch_beacon op.
Andrei says:
Overall it seems ok, but all the purpose of csa_finished is not very
clear..
It looks that this patch tries to avoid extra beaconing on the previous
channel/hitting the warning..
But the problem is much bigger here, it means that we didn't switch in
time (before the next beacon) so it's ok to hit the warning here and
transmit extra beacon with count==1.
So if we see a lot of such warnings, maybe we need to fix
ieee80211_csa_finish instead (not using work for example)
johannes
next prev parent reply other threads:[~2013-12-03 12:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-23 16:38 [PATCH v4] mac80211_hwsim: claim CSA support for AP Karl Beldan
2013-12-03 12:55 ` Johannes Berg [this message]
2013-12-05 17:26 ` Karl Beldan
2013-12-16 12:51 ` Johannes Berg
2013-12-17 16:01 ` Kalle Valo
2014-01-06 18:01 ` Karl Beldan
2014-01-07 15:33 ` Johannes Berg
2014-01-07 17:34 ` Karl Beldan
2014-01-20 11:09 ` Johannes Berg
2014-01-20 13:51 ` Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386075333.4393.13.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrei.otcheretianski@intel.com \
--cc=karl.beldan@gmail.com \
--cc=karl.beldan@rivierawaves.com \
--cc=linux-wireless@vger.kernel.org \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).