From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, j@w1.fi
Subject: Re: [PATCH 4/4] nl80211: add VHT support for set_bitrate_mask
Date: Tue, 03 Dec 2013 15:24:19 +0100 [thread overview]
Message-ID: <1386080659.4393.29.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1386060648-6020-4-git-send-email-janusz.dziedzic@tieto.com> (sfid-20131203_095102_974758_EBAAA3B1)
On Tue, 2013-12-03 at 09:50 +0100, Janusz Dziedzic wrote:
> Add VHT mcs support for nl80211_set_tx_bitrate_mask().
Do we really need more fine-grained control than 0-7/8/9? Why do we need
this at all? :)
> +#define NL80211_MAX_SUPP_VHT_RATES 80
Where does 80 come from? That seems odd?
> + * @NL80211_TXRATE_VHT_MCS: VHT (MCS) rates allowed for TX rate selection
> + * in an array of MCS numbers.
VHT has no "MCS numbers", so this doesn't make much sense?
> if (mask.control[band].legacy == 0) {
> - /* don't allow empty legacy rates if HT
> + /* don't allow empty legacy rates if HT and VHT
> * is not even supported. */
probably should say "are not" now :)
johannes
next prev parent reply other threads:[~2013-12-03 14:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 8:50 [PATCH 1/4] nl80211: don't clear bitrate_mask twice Janusz Dziedzic
2013-12-03 8:50 ` [PATCH 2/4] nl80211: back to default bitrate_mask correctly Janusz Dziedzic
2013-12-03 14:20 ` Johannes Berg
2013-12-03 16:00 ` Janusz Dziedzic
2013-12-04 8:24 ` Johannes Berg
2013-12-03 8:50 ` [PATCH 3/4] nl80211/cfg80211: bitrate_mask, rename mcs to ht_mcs Janusz Dziedzic
2013-12-03 8:50 ` [PATCH 4/4] nl80211: add VHT support for set_bitrate_mask Janusz Dziedzic
2013-12-03 14:24 ` Johannes Berg [this message]
2013-12-03 16:21 ` Janusz Dziedzic
2013-12-04 8:27 ` Johannes Berg
2013-12-04 9:08 ` Janusz Dziedzic
2013-12-04 9:14 ` Johannes Berg
2013-12-03 8:50 ` [PATCH] iw: add VHT MCS set support to set bitrates Janusz Dziedzic
2013-12-03 14:20 ` [PATCH 1/4] nl80211: don't clear bitrate_mask twice Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386080659.4393.29.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox