From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, j@w1.fi
Subject: Re: [PATCH 2/4] nl80211: back to default bitrate_mask correctly
Date: Wed, 04 Dec 2013 09:24:23 +0100 [thread overview]
Message-ID: <1386145463.4284.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CALhHN=otvEjKAWxRvX4KAC4DY39BSeqm-v8mOfyL+M2XLQezYw@mail.gmail.com> (sfid-20131203_170007_540333_5F65286A)
On Tue, 2013-12-03 at 17:00 +0100, Janusz Dziedzic wrote:
> On 3 December 2013 15:20, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Tue, 2013-12-03 at 09:50 +0100, Janusz Dziedzic wrote:
> >> In case of empty NL80211_ATTR_TX_RATES attribute
> >> in nl80211_set_tx_bitrate_mask() function back to
> >> default bitrate mask.
> > Why?
> In case we will execute:
> iw wlanX set bitrate
> with this patch we will back to default - defined by capabilities
> (driver) startup values for both legacy and ht (and VHT with last
> patch).
Maybe add something like that to the commit log - just a single line
would be ok (e.g. "back to the default bitrate mask, to be able to reset
the state") or so?
> Without this patch I don't see an option how to do that from iw. Or I
> miss something
You're right - how did I ever take this code into the tree? Ugh. It
seems it should be reset more often, but I guess we're stuck with it.
johannes
next prev parent reply other threads:[~2013-12-04 8:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 8:50 [PATCH 1/4] nl80211: don't clear bitrate_mask twice Janusz Dziedzic
2013-12-03 8:50 ` [PATCH 2/4] nl80211: back to default bitrate_mask correctly Janusz Dziedzic
2013-12-03 14:20 ` Johannes Berg
2013-12-03 16:00 ` Janusz Dziedzic
2013-12-04 8:24 ` Johannes Berg [this message]
2013-12-03 8:50 ` [PATCH 3/4] nl80211/cfg80211: bitrate_mask, rename mcs to ht_mcs Janusz Dziedzic
2013-12-03 8:50 ` [PATCH 4/4] nl80211: add VHT support for set_bitrate_mask Janusz Dziedzic
2013-12-03 14:24 ` Johannes Berg
2013-12-03 16:21 ` Janusz Dziedzic
2013-12-04 8:27 ` Johannes Berg
2013-12-04 9:08 ` Janusz Dziedzic
2013-12-04 9:14 ` Johannes Berg
2013-12-03 8:50 ` [PATCH] iw: add VHT MCS set support to set bitrates Janusz Dziedzic
2013-12-03 14:20 ` [PATCH 1/4] nl80211: don't clear bitrate_mask twice Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386145463.4284.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox