From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@gmail.com>
Cc: Janusz Dziedzic <janusz.dziedzic@tieto.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH 4/4] nl80211: add VHT support for set_bitrate_mask
Date: Wed, 04 Dec 2013 10:14:22 +0100 [thread overview]
Message-ID: <1386148462.4284.13.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAFED-jkJ0d+AAmjusWXhFH5dutof7VSQkwqK+Ead1M8JUmhjVg@mail.gmail.com> (sfid-20131204_100834_380854_3EA7654F)
On Wed, 2013-12-04 at 10:08 +0100, Janusz Dziedzic wrote:
> Yes, and I added 8 bitmaps:
>
> + u16 vht_mcs[IEEE80211_VHT_NSS_MAX];
But that was the internal API, inside the kernel.
> 80 bytes is because of format we will from user mode (80 available
> combinations for VHT mask).
> I decided for:
> >> 9 - NSS=1, MCS=9
> >> 10 - NSS=2, MCS=0
> >> 11 - NSS=2, MCS=1
> To be compatible with ht-mcs set.
> You mean better to send 8*u16 from user mode and do conversion in IW
> (currently we send 80 bytes and do conversion in nl80211, same as for
> HT)?
But HT MCS is specified that way, there are 77 MCSes in HT, which each
have implicit NSS etc. That's how the standard works for HT. For VHT,
the standard works completely differently.
So yes, I think sending 8 bitmaps from userspace would be much easier to
understand.
johannes
next prev parent reply other threads:[~2013-12-04 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 8:50 [PATCH 1/4] nl80211: don't clear bitrate_mask twice Janusz Dziedzic
2013-12-03 8:50 ` [PATCH 2/4] nl80211: back to default bitrate_mask correctly Janusz Dziedzic
2013-12-03 14:20 ` Johannes Berg
2013-12-03 16:00 ` Janusz Dziedzic
2013-12-04 8:24 ` Johannes Berg
2013-12-03 8:50 ` [PATCH 3/4] nl80211/cfg80211: bitrate_mask, rename mcs to ht_mcs Janusz Dziedzic
2013-12-03 8:50 ` [PATCH 4/4] nl80211: add VHT support for set_bitrate_mask Janusz Dziedzic
2013-12-03 14:24 ` Johannes Berg
2013-12-03 16:21 ` Janusz Dziedzic
2013-12-04 8:27 ` Johannes Berg
2013-12-04 9:08 ` Janusz Dziedzic
2013-12-04 9:14 ` Johannes Berg [this message]
2013-12-03 8:50 ` [PATCH] iw: add VHT MCS set support to set bitrates Janusz Dziedzic
2013-12-03 14:20 ` [PATCH 1/4] nl80211: don't clear bitrate_mask twice Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386148462.4284.13.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=janusz.dziedzic@gmail.com \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox