linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bing Zhao <bzhao@marvell.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"j@w1.fi" <j@w1.fi>
Subject: Re: [RFC] mac80211: implement HS2.0 gratuitous ARP/unsolicited NA dropping
Date: Mon, 16 Dec 2013 12:09:24 +0100	[thread overview]
Message-ID: <1387192164.4665.11.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F70430F532572E0@SC-VEXCH1.marvell.com>

Hi,

> > diff --git a/drivers/net/wireless/mwifiex/decl.h b/drivers/net/wireless/mwifiex/decl.h
> > index 5c85d78..1887629 100644
> > --- a/drivers/net/wireless/mwifiex/decl.h
> > +++ b/drivers/net/wireless/mwifiex/decl.h
> > @@ -153,12 +153,4 @@ struct mwifiex_types_wmm_info {
> >  	u8 reserved;
> >  	struct ieee_types_wmm_ac_parameters ac_params[IEEE80211_NUM_ACS];
> >  } __packed;
> > -
> > -struct mwifiex_arp_eth_header {
> > -	struct arphdr hdr;
> > -	u8 ar_sha[ETH_ALEN];
> > -	u8 ar_sip[4];
> > -	u8 ar_tha[ETH_ALEN];
> > -	u8 ar_tip[4];
> > -} __packed;
> 
> "#include <uapi/linux/if_arp.h" in this file can be removed too.

Indeed, good catch. I'll roll this into my patch, but due to
holidays/vacation I won't actually work on it until January or so.

johannes


  reply	other threads:[~2013-12-16 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 18:56 [RFC] mac80211: implement HS2.0 gratuitous ARP/unsolicited NA dropping Johannes Berg
2013-12-14  2:44 ` Bing Zhao
2013-12-16 11:09   ` Johannes Berg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-11-21 13:58 Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387192164.4665.11.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=bzhao@marvell.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).