From: Johannes Berg <johannes@sipsolutions.net>
To: Chet Lanctot <clanctot@codeaurora.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2 V3] nl80211/cfg80211: Enable station PMF requirement to be specified to driver with AP SME
Date: Mon, 16 Dec 2013 15:26:39 +0100 [thread overview]
Message-ID: <1387203999.2057.12.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1386713477-30040-3-git-send-email-clanctot@codeaurora.org> (sfid-20131210_231133_211429_52E9E479)
On Tue, 2013-12-10 at 14:11 -0800, Chet Lanctot wrote:
> + if (info->attrs[NL80211_ATTR_USE_MFP]) {
> + params.mfp = nla_get_u32(info->attrs[NL80211_ATTR_USE_MFP]);
> + if (params.mfp != NL80211_MFP_REQUIRED &&
> + params.mfp != NL80211_MFP_OPTIONAL &&
> + params.mfp != NL80211_MFP_NO)
> + return -EINVAL;
> + } else
> + params.mfp = NL80211_MFP_NO;
Code style.
Wouldn't a feature flag be needed?
johannes
next prev parent reply other threads:[~2013-12-16 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 22:11 [PATCH 0/2 V3] nl80211/cfg80211: Support PMF on drivers with integrated AP SME Chet Lanctot
2013-12-10 22:11 ` [PATCH 1/2 V3] nl80211/cfg80211: Add support for drivers with AP SME that require PMF SA Query assistance Chet Lanctot
2013-12-16 14:19 ` Johannes Berg
2013-12-10 22:11 ` [PATCH 2/2 V3] nl80211/cfg80211: Enable station PMF requirement to be specified to driver with AP SME Chet Lanctot
2013-12-16 14:26 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-03 21:30 clanctot
2014-01-06 16:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387203999.2057.12.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=clanctot@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).