Re: [PATCH v4] cfg80211: fix dfs channel state after stopping AP

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2013-12-16 at 11:55 +0100, Marek Puzyniak wrote:
> In AP mode DFS channel state is changed to DFS_AVAILABLE
> after successful CAC and remains as such until a radar
> signal is detected during the In-Service Monitoring.
> When AP is stopped it is no longer monitoring current channel
> for radar signals. DFS channel state should be changed
> to DFS_USABLE when last AP interface is stopped. Starting AP
> again on that channel will start CAC instead of starting radiation.

If you keep changing your patch without any changelog (after the "---"
line!) then I have no idea what I should look at?

> +	if (rdev->num_running_ifaces == 1) {
> +		/* Last running AP iface*/

missing a space

> +		wdev_lock(wdev_iter);

This will almost certainly cause a lockdep warning since you hold the
wdev lock already.

> +		if (!netif_running(wdev_iter->netdev)) {
> +			wdev_unlock(wdev_iter);
> +			continue;
> +		}
> +
> +		if (wdev_iter->iftype == NL80211_IFTYPE_AP) {
> +			wdev_unlock(wdev_iter);
> +			return false;
> +		}
> +		wdev_unlock(wdev_iter);

I don't think checking the iftype needs the lock (this lock - maybe
rtnl) anyway?

johannes