From: Johannes Berg <johannes@sipsolutions.net>
To: Jones Desougi <jones.desougi@27m.se>
Cc: linux-wireless@vger.kernel.org, sw@simonwunderlich.de
Subject: Re: [PATCH] mac80211: fix iflist_mtx/mtx locking in radar detection
Date: Wed, 18 Dec 2013 18:02:59 +0100 [thread overview]
Message-ID: <1387386179.4694.16.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <52B1D446.9030808@27m.se> (sfid-20131218_175848_996438_4667D057)
On Wed, 2013-12-18 at 17:58 +0100, Jones Desougi wrote:
> One locking oddness below.
> > @@ -301,6 +302,7 @@ static void __ieee80211_sta_join_ibss(struct ieee80211_sub_if_data *sdata,
> > sdata_info(sdata, "Failed to join IBSS, no channel context\n");
> > return;
> > }
> > + mutex_unlock(&local->mtx);
>
> At least looking at the patch only, the return above without unlock
> seems suspicious.
Indeed. But please trim your quotes in the future :)
johannes
prev parent reply other threads:[~2013-12-18 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 9:13 [PATCH] mac80211: fix iflist_mtx/mtx locking in radar detection Johannes Berg
2013-12-18 14:51 ` Simon Wunderlich
2013-12-18 16:58 ` Jones Desougi
2013-12-18 17:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387386179.4694.16.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jones.desougi@27m.se \
--cc=linux-wireless@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).