From: Johannes Berg <johannes@sipsolutions.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Ben Greear <greearb@candelatech.com>,
Joe Perches <joe@perches.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
kernel-janitors@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/11] use ether_addr_equal_64bits
Date: Mon, 06 Jan 2014 11:17:47 +0100 [thread overview]
Message-ID: <1389003467.5891.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <alpine.DEB.2.10.1401061007160.2079@hadrien>
On Mon, 2014-01-06 at 10:09 +0100, Julia Lawall wrote:
> > BUILD_BUG_ON(sizeof(struct foo) - offsetof(struct foo, addr) < 8);
> >
> > with the user(s?) and that should catch the scenario I was worrying
> > about?
>
> OK, thanks. That is what I had in mind. But I was hoping to be able to
> put it with the structure.
Right - you might be able to do that with BUILD_BUG_ON_ZERO() as you
pointed out, I haven't looked at these macros in a while.
> Perhaps there is a way to make a macro that
> expands to a dummy function that contains the BUILD_BUG_ON? But I guess
> that would waste space?
>
> I think that 8 should be 16?
No, that should be ETH_ALEN+2 really, I guess - it's not taking into
account the size of the address member itself at all.
johannes
next prev parent reply other threads:[~2014-01-06 10:18 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 18:14 [PATCH 0/11] use ether_addr_equal_64bits Julia Lawall
2013-12-30 18:14 ` [PATCH 1/11] rt2x00: " Julia Lawall
2013-12-31 16:44 ` Gertjan van Wingerde
2013-12-30 18:14 ` [PATCH 2/11] ath5k: " Julia Lawall
2013-12-30 18:14 ` [PATCH 3/11] mac80211: " Julia Lawall
2013-12-30 18:10 ` Christian Lamparter
2013-12-30 18:15 ` [PATCH 4/11] " Julia Lawall
2013-12-30 18:56 ` Johannes Berg
2013-12-30 19:58 ` Julia Lawall
2013-12-30 21:25 ` Johannes Berg
2013-12-30 21:57 ` Henrique de Moraes Holschuh
2013-12-30 23:13 ` Johannes Berg
2013-12-30 23:17 ` Joe Perches
2013-12-31 6:32 ` Julia Lawall
2013-12-31 15:54 ` Ben Greear
2013-12-31 16:09 ` Julia Lawall
2013-12-31 16:27 ` Ben Greear
2013-12-31 16:40 ` Julia Lawall
2014-01-06 9:05 ` Johannes Berg
2014-01-06 9:09 ` Julia Lawall
2014-01-06 10:17 ` Johannes Berg [this message]
2014-01-06 8:48 ` Julia Lawall
2014-01-06 8:59 ` Joe Perches
2014-01-06 9:04 ` Julia Lawall
2014-01-06 9:07 ` Johannes Berg
2014-01-06 9:20 ` Julia Lawall
2013-12-31 6:26 ` Emmanuel Grumbach
2014-01-06 9:24 ` Geert Uytterhoeven
2014-01-06 9:35 ` Julia Lawall
2014-01-06 15:18 ` Eric Dumazet
2014-01-06 10:48 ` Dan Carpenter
2014-01-17 10:18 ` Dan Carpenter
2013-12-30 18:15 ` [PATCH 5/11] mwl8k: " Julia Lawall
2013-12-30 18:15 ` [PATCH 6/11] rtlwifi: " Julia Lawall
2013-12-30 21:08 ` Larry Finger
2013-12-30 18:15 ` [PATCH 7/11] iwlegacy: " Julia Lawall
2013-12-30 18:15 ` [PATCH 8/11] " Julia Lawall
2013-12-30 18:15 ` [PATCH 9/11] ipw2x00: " Julia Lawall
2013-12-30 18:15 ` [PATCH 10/11] at76c50x-usb: " Julia Lawall
2013-12-30 18:15 ` [PATCH 11/11] carl9170: " Julia Lawall
2013-12-30 18:10 ` Christian Lamparter
2014-01-17 21:24 ` [PATCH 0/11] " Pavel Machek
2014-01-17 22:02 ` Oleksij Rempel
2014-01-17 22:43 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389003467.5891.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=greearb@candelatech.com \
--cc=hmh@hmh.eng.br \
--cc=ilw@linux.intel.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).