From: Chaitanya T K <chaitanya.mgit@gmail.com>
To: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Cc: Chaitanya T K <chaitanya.mgit@gmail.com>
Subject: [PATCH] cfg80211: Do not call CRDA when using internal regulatory database
Date: Fri, 17 Jan 2014 03:32:38 +0530 [thread overview]
Message-ID: <1389909758-6807-1-git-send-email-chaitanya.mgit@gmail.com> (raw)
When using internal regulatory data base kconfig option
do not try to call crda, this complely defeats the
purposes of enabling internal regulatory db.
Signed-off-by: Chaitanya T K <chaitanya.mgit@gmail.com>
---
net/wireless/reg.c | 29 +++++++++++++++--------------
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index 7d20d84..1cb0f99 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -454,16 +454,16 @@ static void reg_regdb_search(struct work_struct *work)
static DECLARE_WORK(reg_regdb_work, reg_regdb_search);
-static void reg_regdb_query(const char *alpha2)
+static int reg_regdb_query(const char *alpha2)
{
struct reg_regdb_search_request *request;
if (!alpha2)
- return;
+ return -1;
request = kzalloc(sizeof(struct reg_regdb_search_request), GFP_KERNEL);
if (!request)
- return;
+ return -1;
memcpy(request->alpha2, alpha2, 2);
@@ -472,6 +472,7 @@ static void reg_regdb_query(const char *alpha2)
mutex_unlock(®_regdb_search_mutex);
schedule_work(®_regdb_work);
+ return 0;
}
/* Feel free to add any other sanity checks here */
@@ -482,7 +483,15 @@ static void reg_regdb_size_check(void)
}
#else
static inline void reg_regdb_size_check(void) {}
-static inline void reg_regdb_query(const char *alpha2) {}
+static inline int reg_regdb_query(const char *alpha2)
+{
+ if (!is_world_regdom((char *) alpha2))
+ pr_info("Calling CRDA for country: %c%c\n",
+ alpha2[0], alpha2[1]);
+ else
+ pr_info("Calling CRDA to update world regulatory domain\n");
+ return kobject_uevent(®_pdev->dev.kobj, KOBJ_CHANGE);
+}
#endif /* CONFIG_CFG80211_INTERNAL_REGDB */
/*
@@ -492,16 +501,8 @@ static inline void reg_regdb_query(const char *alpha2) {}
*/
static int call_crda(const char *alpha2)
{
- if (!is_world_regdom((char *) alpha2))
- pr_info("Calling CRDA for country: %c%c\n",
- alpha2[0], alpha2[1]);
- else
- pr_info("Calling CRDA to update world regulatory domain\n");
-
- /* query internal regulatory database (if it exists) */
- reg_regdb_query(alpha2);
-
- return kobject_uevent(®_pdev->dev.kobj, KOBJ_CHANGE);
+ /* query internal regulatory database/crda depending on config */
+ return reg_regdb_query(alpha2);
}
static enum reg_request_treatment
next reply other threads:[~2014-01-16 22:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 22:02 Chaitanya T K [this message]
2014-01-17 18:52 ` [PATCH] cfg80211: Do not call CRDA when using internal regulatory database Krishna Chaitanya
2014-01-17 18:54 ` Johannes Berg
2014-01-17 18:55 ` Johannes Berg
2014-01-17 19:03 ` Krishna Chaitanya
2014-01-17 22:10 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389909758-6807-1-git-send-email-chaitanya.mgit@gmail.com \
--to=chaitanya.mgit@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox