From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/7] mac80211: improve CSA locking
Date: Wed, 22 Jan 2014 09:52:06 +0100 [thread overview]
Message-ID: <1390380726.4334.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQmsROawL=bcyiXM+zCWKfKr7KPRvDoojKfoCByV97zSUw@mail.gmail.com> (sfid-20140122_075114_139752_88E4FB38)
On Wed, 2014-01-22 at 07:51 +0100, Michal Kazior wrote:
> > I mean this:
> >
> >> + sdata->csa_chandef = params.chandef;
> >
> > doesn't seem to belong here.
>
> I mistakenly left that while rebasing. I'll fix that. I think that's
> the only thing that shouldn't be in this patch?
It's the only thing I found, but ... :)
> > It would also be good to explain why you're doing this?
>
> You mean the whole locking patch? Basically to be able safely assess
> CSA state. Taking a bunch of wdev->mtx seems like a bad idea. Due to
> how the locks are ordered and organized I've came up with using
> local->mtx as an extra CSA-related variable protection. Using
> local->mtx makes it possible to iterate over interfaces and check
> for/update CSA state in an atomic way.
>
> Is this a satisfactory explanation?
Almost - where exactly do you need that? I'm just trying to weigh this
patch vs. the other that I didn't like to see if this is needed
regardless of the particular approach of how we switch channels later.
johannes
next prev parent reply other threads:[~2014-01-22 8:52 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 14:21 [PATCH 0/7] mac80211: CSA related fixes Michal Kazior
2014-01-20 14:21 ` [PATCH 1/7] mac80211: fix possible memory leak on AP CSA failure Michal Kazior
2014-01-21 14:55 ` Johannes Berg
2014-01-22 6:54 ` Michal Kazior
2014-01-20 14:21 ` [PATCH 2/7] mac80211: treat IBSS CSA finish failure seriously Michal Kazior
2014-01-21 15:00 ` Johannes Berg
2014-01-22 11:38 ` Luca Coelho
2014-01-20 14:21 ` [PATCH 3/7] mac80211: move csa_active setting in STA CSA Michal Kazior
2014-01-22 11:40 ` Luca Coelho
2014-01-20 14:21 ` [PATCH 4/7] mac80211: fix sdata->radar_required locking Michal Kazior
2014-01-20 14:21 ` [PATCH 5/7] mac80211: improve CSA locking Michal Kazior
2014-01-20 15:41 ` Michal Kazior
2014-01-21 15:06 ` Johannes Berg
2014-01-22 6:51 ` Michal Kazior
2014-01-22 8:52 ` Johannes Berg [this message]
2014-01-22 9:07 ` Michal Kazior
2014-01-22 9:13 ` Johannes Berg
2014-01-22 10:13 ` Michal Kazior
2014-01-22 10:19 ` Johannes Berg
2014-01-22 12:36 ` Luca Coelho
2014-01-22 15:10 ` Johannes Berg
2014-01-22 15:13 ` Luca Coelho
2014-01-23 6:22 ` Michal Kazior
2014-01-23 6:31 ` Luca Coelho
2014-01-23 6:41 ` Michal Kazior
2014-01-23 7:31 ` Luca Coelho
2014-01-23 7:50 ` Otcheretianski, Andrei
2014-01-23 7:57 ` Michal Kazior
2014-01-23 9:50 ` Luca Coelho
2014-01-23 10:33 ` Michal Kazior
2014-01-23 12:20 ` Johannes Berg
2014-01-23 12:38 ` Michal Kazior
2014-01-24 7:41 ` Luca Coelho
2014-01-24 8:40 ` Johannes Berg
2014-01-24 9:52 ` Luca Coelho
2014-01-24 10:40 ` Michal Kazior
2014-01-24 12:55 ` Luca Coelho
2014-01-23 12:09 ` Johannes Berg
2014-01-23 12:41 ` Michal Kazior
2014-01-24 7:44 ` Luca Coelho
2014-01-23 6:35 ` Luca Coelho
2014-01-23 12:07 ` Johannes Berg
2014-01-23 6:35 ` Michal Kazior
2014-01-23 12:06 ` Johannes Berg
2014-01-20 14:21 ` [PATCH 6/7] mac80211: deny attempts at using chanctx during CSA Michal Kazior
2014-01-20 21:41 ` Luca Coelho
2014-01-21 6:07 ` Michal Kazior
2014-01-21 15:14 ` Johannes Berg
2014-01-20 14:21 ` [PATCH 7/7] Revert "cfg80211: disable CSA for all drivers" Michal Kazior
2014-01-21 15:16 ` [PATCH 0/7] mac80211: CSA related fixes Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390380726.4334.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).