From: Johannes Berg <johannes@sipsolutions.net>
To: Chaitanya T K <chaitanya.mgit@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] minstrel_ht: Use RTS_CTS when STA is in DYNAMIC SMPS mode for frames sent using Nss>1.
Date: Wed, 22 Jan 2014 22:27:02 +0100 [thread overview]
Message-ID: <1390426022.4334.50.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1390373865-6088-1-git-send-email-chaitanya.mgit@gmail.com> (sfid-20140122_220916_338336_2620AEB0)
On Wed, 2014-01-22 at 12:27 +0530, Chaitanya T K wrote:
> + if (sta->smps_mode == IEEE80211_SMPS_DYNAMIC &&
> + minstrel_mcs_groups[i].streams > 1) {
> + mi->tx_flags |= IEEE80211_TX_RC_USE_RTS_CTS;
> + } else if (sta->smps_mode == IEEE80211_SMPS_STATIC &&
> + minstrel_mcs_groups[i].streams > 1) {
Your indentation is off inside the if statements. I'll have to wait for
nbd to review the patch itself, I guess.
johannes
PS: Your clock/timezone is wrong by approximately 10 hours.
next prev parent reply other threads:[~2014-01-22 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-22 6:57 [PATCH] minstrel_ht: Use RTS_CTS when STA is in DYNAMIC SMPS mode for frames sent using Nss>1 Chaitanya T K
2014-01-22 21:27 ` Johannes Berg [this message]
2014-01-22 21:53 ` Krishna Chaitanya
2014-01-30 18:18 ` Krishna Chaitanya
2015-06-01 18:19 ` Krishna Chaitanya
2015-06-01 20:36 ` Johannes Berg
2015-06-01 21:33 ` Krishna Chaitanya
2015-06-01 21:40 ` Johannes Berg
2015-06-02 18:29 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390426022.4334.50.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).