From: Johannes Berg <johannes@sipsolutions.net>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [mac80211] BUG: unable to handle kernel paging request at 6b6b6b8f
Date: Fri, 24 Jan 2014 13:17:50 +0100 [thread overview]
Message-ID: <1390565870.4257.40.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <20140124120840.GA25638@localhost> (sfid-20140124_131240_755302_221A9D31)
On Fri, 2014-01-24 at 20:08 +0800, Fengguang Wu wrote:
> Hi Johannes,
>
> The BUG does not show up in linux-next 20140124, is it fixed now?
It isn't in linux-next yet I believe (mac80211-next isn't in there), but
yeah, I fixed it already, ran into it myself yesterday. Hope it didn't
cause you too much trouble. The problem was that I misplaced some code
because I didn't notice that the if () condition (see below) had no
braces.
I replaced that commit with
commit 091a69f86862454c282d4a64c9d66074e60514ea
Author: Johannes Berg <johannes.berg@intel.com>
Date: Wed Jan 22 10:36:59 2014 +0100
mac80211: remove module handling from rate control ops
which now contains this change
list_for_each_entry(alg, &rate_ctrl_algs, list) {
- if (!strcmp(alg->ops->name, name))
- if (try_module_get(alg->ops->module)) {
- ops = alg->ops;
- break;
- }
+ if (!strcmp(alg->ops->name, name)) {
+ ops = alg->ops;
+ break;
+ }
}
(note the new set of braces added around the content of the strcmp if)
Sorry!
johannes
next prev parent reply other threads:[~2014-01-24 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 12:08 [mac80211] BUG: unable to handle kernel paging request at 6b6b6b8f Fengguang Wu
2014-01-24 12:17 ` Johannes Berg [this message]
2014-01-24 12:35 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390565870.4257.40.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).