From: Johannes Berg <johannes@sipsolutions.net>
To: Ujjal Roy <royujjal@gmail.com>
Cc: WiFi Mailing List <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] iw: add support for retry limit
Date: Fri, 24 Jan 2014 16:00:02 +0100 [thread overview]
Message-ID: <1390575602.4257.44.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1389273736-9486-1-git-send-email-royujjal@gmail.com> (sfid-20140109_142238_521185_44E25359)
On Thu, 2014-01-09 at 18:52 +0530, Ujjal Roy wrote:
Sorry for the late reply.
> @@ -232,6 +232,45 @@ COMMAND(set, rts, "<rts threshold|off>",
> NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_rts,
> "Set rts threshold.");
>
> +static int handle_retry(struct nl80211_state *state,
> + struct nl_cb *cb, struct nl_msg *msg,
> + int argc, char **argv,
> + enum id_input id)
indentation is a bit off
> +COMMAND(set, retry, "<short limit> [<long limit>]",
> + NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_retry,
> + "Set retry limit.");
This seems odd to me, why would you want to allow setting the short
limit while not changing the long one, but not the other way around?
johannes
next prev parent reply other threads:[~2014-01-24 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 13:22 [RFC] iw: add support for retry limit Ujjal Roy
2014-01-24 15:00 ` Johannes Berg [this message]
2014-01-30 11:13 ` [PATCHv2] iw: add support to set/get " Ujjal Roy
2014-01-30 11:20 ` Ujjal Roy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390575602.4257.44.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=royujjal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox