Re: [PATCH] nl80211: fix scheduled scan RSSI matchset attribute confusion

[Johannes Berg <johannes@sipsolutions.net>]

On Sat, 2014-01-25 at 05:46 +0000, Mani, Raja wrote:
> >@@ -5669,15 +5708,28 @@ static int nl80211_start_sched_scan(struct sk_buff *skb,
> >                                       nla_data(ssid), nla_len(ssid));
> >                                request->match_sets[i].ssid.ssid_len =
> >                                        nla_len(ssid);
> >+                               /* special attribute - old implemenation w/a */
> >+                               request->match_sets[i].rssi_thold =
> >+                                       default_match_rssi;
> 
> How about this case where RSSI is disabled for SSID1 and and SSID 4
> and only SSID2 and SSID3 needs RSSI filter.
> 
>    SSID1, SSID2, RSSI, SSID3, RSSI, SSID4
> 
> Wouldn't this change set RSSI of SSID3 to SSID1 and SSID4 ?
> Did i miss to understand anything ?

It's not a case that was previously supported. Previously, all you could
do was

{ SSID1 | SSID2 | SSID3 } + RSSI

Now, you can do

{ (SSID1, RSSI1) | (SSID2, RSSI2) | (SSID3, RSSI3) }

IOW, it wouldn't change anything - note how the RSSI value before used
to set request->rssi_thold, and not request->matchsets[i].rssi_thold.

johannes