From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, mcgrof@do-not-panic.com
Subject: Re: [PATCH v4] cfg80211: regulatory introduce maximum bandwidth calculation
Date: Fri, 31 Jan 2014 15:07:54 +0100 [thread overview]
Message-ID: <1391177274.4141.21.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1391071940-4296-1-git-send-email-janusz.dziedzic@tieto.com> (sfid-20140130_095240_969875_701DF578)
On Thu, 2014-01-30 at 09:52 +0100, Janusz Dziedzic wrote:
I'll apply this, but I think we should think about this:
> @@ -950,11 +1027,18 @@ static void handle_channel(struct wiphy *wiphy,
> + max_bandwidth_khz = freq_range->max_bandwidth_khz;
> + /* Check if auto calculation requested */
> + if (!max_bandwidth_khz) {
> + regd = reg_get_regdomain(wiphy);
> + max_bandwidth_khz = reg_get_max_bandwidth(regd, reg_rule);
> + }
It seems rather odd to have to look up the regdomain here, when we
actually came from a regdomain update originally. Or didn't we?
johannes
next prev parent reply other threads:[~2014-01-31 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 8:52 [PATCH v4] cfg80211: regulatory introduce maximum bandwidth calculation Janusz Dziedzic
2014-01-31 14:07 ` Johannes Berg [this message]
2014-01-31 16:18 ` Janusz Dziedzic
2014-01-31 20:04 ` Johannes Berg
2014-02-19 18:51 ` Luis R. Rodriguez
2014-02-20 6:07 ` Janusz Dziedzic
2014-02-20 7:08 ` Johannes Berg
2014-02-20 7:25 ` Janusz Dziedzic
2014-02-21 23:08 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391177274.4141.21.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).