Re: [PATCH v4] cfg80211: regulatory introduce maximum bandwidth calculation

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2014-01-31 at 17:18 +0100, Janusz Dziedzic wrote:
> On 31 January 2014 15:07, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Thu, 2014-01-30 at 09:52 +0100, Janusz Dziedzic wrote:
> >
> > I'll apply this, but I think we should think about this:
> >
> >> @@ -950,11 +1027,18 @@ static void handle_channel(struct wiphy *wiphy,
> >
> >> +     max_bandwidth_khz = freq_range->max_bandwidth_khz;
> >> +     /* Check if auto calculation requested */
> >> +     if (!max_bandwidth_khz) {
> >> +             regd = reg_get_regdomain(wiphy);
> >> +             max_bandwidth_khz = reg_get_max_bandwidth(regd, reg_rule);
> >> +     }
> >
> > It seems rather odd to have to look up the regdomain here, when we
> > actually came from a regdomain update originally. Or didn't we?
> >
> In the handle_channel() function we don't know regd.
> 
> reg_rule = freq_reg_info(wiphy, MHZ_TO_KHZ(chan->center_freq));

Yeah I thought we had it in the callers, maybe not then.

johannes