linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: greearb@candelatech.com
To: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Ben Greear <greearb@candelatech.com>
Subject: [PATCH 2/2] ath10k:  do not ratelimit ath10k_warn messages
Date: Thu, 13 Feb 2014 11:09:22 -0800	[thread overview]
Message-ID: <1392318562-32440-2-git-send-email-greearb@candelatech.com> (raw)
In-Reply-To: <1392318562-32440-1-git-send-email-greearb@candelatech.com>

From: Ben Greear <greearb@candelatech.com>

These are too important to miss, and if we ever do have some
that are overly verbose, could ratelimit the call to ath10k_warn
instead of doing the ratelimit inside of ath10k_warn.

Signed-off-by: Ben Greear <greearb@candelatech.com>
---
 drivers/net/wireless/ath/ath10k/debug.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 6debd28..c922e39 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -89,8 +89,7 @@ int ath10k_warn(const char *fmt, ...)
 	va_start(args, fmt);
 	vaf.va = &args;
 
-	if (net_ratelimit())
-		ret = ath10k_printk(KERN_WARNING, "%pV", &vaf);
+	ret = ath10k_printk(KERN_WARNING, "%pV", &vaf);
 
 	trace_ath10k_log_warn(&vaf);
 
-- 
1.7.11.7


  reply	other threads:[~2014-02-13 19:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 19:09 [PATCH 1/2] ath10k: add vdev-id, return code to error codes greearb
2014-02-13 19:09 ` greearb [this message]
2014-02-13 19:56   ` [PATCH 2/2] ath10k: do not ratelimit ath10k_warn messages Kalle Valo
2014-02-13 20:32     ` Ben Greear
2014-02-14  6:06 ` [PATCH 1/2] ath10k: add vdev-id, return code to error codes Kalle Valo
2014-02-14 15:33   ` Ben Greear
2014-03-03 15:32     ` Kalle Valo
2014-02-26 18:28   ` Ben Greear
2014-02-27  8:43     ` Kalle Valo
2014-03-03 15:39 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392318562-32440-2-git-send-email-greearb@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).