From: Johannes Berg <johannes@sipsolutions.net>
To: Justin van Wijngaarden <justinvanwijngaarden@gmail.com>
Cc: linville@tuxdriver.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Drivers: net: wireless: mac80211_hwim fixed coding style issues
Date: Sat, 15 Feb 2014 19:13:50 +0100 [thread overview]
Message-ID: <1392488030.4298.5.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1392465312-3780-1-git-send-email-justinvanwijngaarden@gmail.com> (sfid-20140215_125633_755512_88424C91)
On Sat, 2014-02-15 at 12:55 +0100, Justin van Wijngaarden wrote:
> @@ -1,19 +1,17 @@
> -/*
> - * mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211
> +/* mac80211_hwsim - software simulator of 802.11 radio(s) for mac80211
I don't see any point in this - lots of code exists both ways, that's
really just fluff. The difference isn't even interesting enough to be
worth fixing up.
> * published by the Free Software Foundation.
> - */
> +*/
That's just wrong.
In any case, your patch won't apply anyway since we've since
changed/removed code that you're modifying.
There's very little in this patch that I'd be willing to apply, and most
of that you actually got the coding style wrong so it's not an
improvement at all.
johannes
next prev parent reply other threads:[~2014-02-15 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 11:55 [PATCH] Drivers: net: wireless: mac80211_hwim fixed coding style issues Justin van Wijngaarden
2014-02-15 18:13 ` Johannes Berg [this message]
2014-02-15 19:53 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392488030.4298.5.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=justinvanwijngaarden@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).