From: Johannes Berg <johannes@sipsolutions.net>
To: Fariya Fatima <fariya.f@redpinesignals.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3.14.0-rc5 v3 3/10] rsi: Adding core and main files
Date: Wed, 05 Mar 2014 12:02:48 +0100 [thread overview]
Message-ID: <1394017368.5275.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <53143A80.5010907@redpinesignals.com> (sfid-20140303_091846_012550_AEC79CCE)
On Mon, 2014-03-03 at 13:47 +0530, Fariya Fatima wrote:
> + * @return 0 on success, -1 on failure.
The function should be void, you don't use its return value, nor would
that make sense.
> +xmit_fail:
> + rsi_dbg(ERR_ZONE, "%s: Failed to queue packet\n", __func__);
> + if (skb)
> + dev_kfree_skb(skb);
You need to use the mac80211 free function for xmit skbs.
johannes
next prev parent reply other threads:[~2014-03-05 11:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 8:17 [PATCH 3.14.0-rc5 v3 3/10] rsi: Adding core and main files Fariya Fatima
2014-03-05 10:55 ` Johannes Berg
2014-03-05 10:56 ` Johannes Berg
2014-03-05 11:02 ` Johannes Berg [this message]
[not found] <-1822952301-40502@mail.redpinesignals.com>
2014-03-05 17:58 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394017368.5275.17.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fariya.f@redpinesignals.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).