From: Johannes Berg <johannes@sipsolutions.net>
To: Fariya Fatima <fariya.f@redpinesignals.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3.14.0-rc5 v3 6/10] rsi: MAC80211 callbacks and management functions internal to device
Date: Wed, 05 Mar 2014 12:13:35 +0100 [thread overview]
Message-ID: <1394018015.5275.24.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <53143B7C.5030602@redpinesignals.com> (sfid-20140303_092250_887269_13F7DCB5)
On Mon, 2014-03-03 at 13:51 +0530, Fariya Fatima wrote:
> +int rsi_mac80211_attach(struct rsi_common *common)
> +{
> + int status = 0;
> + struct ieee80211_hw *hw = NULL;
> + struct wiphy *wiphy = NULL;
> + struct rsi_hw *adapter = common->priv;
> + u8 addr_mask[ETH_ALEN] = {0x0, 0x0, 0x0, 0x0, 0x0, 0x3};
> + struct ieee80211_supported_band *sband = &adapter->sbands[0];
This is pretty odd
> + wiphy->bands[IEEE80211_BAND_2GHZ] = &sband[IEEE80211_BAND_2GHZ];
combined with that.
> + /* wiphy->bands[IEEE80211_BAND_5GHZ] = &sband[IEEE80211_BAND_5GHZ]; */
> +
> + status = ieee80211_register_hw(hw);
> + if (status)
> + return status;
> +
> +#ifdef CONFIG_RSI_DEBUGFS
> + if (rsi_init_dbgfs(adapter)) {
similar comment here like with the teardown.
> + rsi_dbg(ERR_ZONE, "%s: dbgfs not created\n", __func__);
> + return -1;
-1 is also not a good error code, like before
johannes
next prev parent reply other threads:[~2014-03-05 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 8:21 [PATCH 3.14.0-rc5 v3 6/10] rsi: MAC80211 callbacks and management functions internal to device Fariya Fatima
2014-03-05 11:13 ` Johannes Berg [this message]
2014-03-05 11:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394018015.5275.24.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fariya.f@redpinesignals.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).