Re: [PATCH 3.14.0-rc5 v3 3/10] rsi: Adding core and main files

[Johannes Berg <johannes@sipsolutions.net>]

Hi,

[please don't send HTML emails, the list will drop those]

> In our code, we do fill in skb->priority field as you have seen. Once
> the pkt comes over to my driver, I thought I could over-write the
> priority field as I don't see this field being used again by the
> mac80211 stack. Even in case there is a failure and I call the
> ieee80211_free_txskb( ), I don't see that field being used.
> Considering this, can I not re-use the field within my driver or am I
> missing something in here?

No, I guess you can do that. However, there are cases where the packet
could potentially be reprocessed by mac80211, notably in the AP-side
code for handling powersave clients (ieee80211_sta_ps_deliver_response).
These code paths aren't executed for your driver right now, so this
isn't really a concern, but if you plan on adding AP/GO support then it
might be worth using a field inside skb->cb instead where you already
have other fields.

IOW, it's fine right now, but if you extend your code in the future you
may run into hard to debug issues with it.

johannes