Re: [PATCH 3.14.0-rc5 v3 1/10] rsi: Adding RS9113 driver files

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2014-03-05 at 23:28 +0530, Fariya Fathima wrote:

> The num_debugfs entries corresponds to the number of debugfs entries
> to be created by the core layer.  Our driver has support for 2
> interfaces - SDIO & USB. The SDIO driver intends to create 4 debugfs
> entries and the USB driver intends to create 3. This information is
> indicated to the core layer by initializing the num_debufs entries,
> depending on the interface.

Yeah I got confused with this. I guess it's OK, although likely to break
in the future? Maybe the SDIO layer should provide that one debugfs
handler itself, rather than having it in the core, so that this
distinction isn't needed?

> These seem odd ... maybe they should at least come with comments
> about 
> how generic kernel functionality can't be used and why it needs
> another 
> abstraction layer?
> We did put in various fields inside the rsi_event and rsi_thread
> structs to create a slight abstraction. I hope that is fine.

I have no issues with that really, it just seems odd, but maybe it just
means the kernel functionality isn't precisely what you need.

johannes