Re: [PATCH v6 2/3] mac80211: implement chanctx reservation

[Luciano Coelho <luciano.coelho@intel.com>]

On Sun, 2014-03-09 at 17:08 +0200, Eliad Peller wrote:
> hi Luca,
> 
> On Sun, Mar 9, 2014 at 4:40 PM, Luciano Coelho <luciano.coelho@intel.com> wrote:
> > In order to support channel switch with multiple vifs and multiple
> > contexts, we implement a concept of channel context reservation.  This
> > allows us to reserve a channel context to be used later.
> >
> > The reservation functionality is not tied directly to channel switch
> > and may be used in other situations (eg. reserving a channel context
> > during IBSS join).
> >
> > We first check if an existing compatible context exists and if it
> > does, we reserve it.  If there is no compatible context we create a
> > new one and reserve it.
> >
> > Signed-off-by: Luciano Coelho <luciano.coelho@intel.com>
> > ---
> [...]
> 
> > +int ieee80211_vif_use_reserved_context(struct ieee80211_sub_if_data *sdata,
> > +                                      u32 *changed)
> > +{
> [...]
> > +
> > +       *changed = local_changed;
> > +
> > +       ieee80211_recalc_chanctx_chantype(local, ctx);
> > +       ieee80211_recalc_smps_chanctx(local, ctx);
> > +       ieee80211_recalc_radar_chanctx(local, ctx);
> 
> any reason for not calling ieee80211_recalc_chanctx_min_def() as well?

No, it's just missing. :( I'll add it.

--
Luca.