From: Johannes Berg <johannes@sipsolutions.net>
To: Eliad Peller <eliad@wizery.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] mac80211: fix racy usage of chanctx->refcount
Date: Mon, 10 Mar 2014 22:29:42 +0200 [thread overview]
Message-ID: <1394483382.30155.2.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAB3XZEek76hKh_5nqOs66DgFHT9iki17rZD8EqJnccQty4FdeQ@mail.gmail.com> (sfid-20140309_104027_325761_F4E44E1B)
On Sun, 2014-03-09 at 11:40 +0200, Eliad Peller wrote:
> > @@ -3233,23 +3233,23 @@ int ieee80211_channel_switch(struct wiphy *wiphy, struct net_device *dev,
> > &sdata->vif.bss_conf.chandef))
> > return -EINVAL;
> >
> > - rcu_read_lock();
> > + mutex_lock(&local->chanctx_mtx);
> > chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf);
> this should probably be rcu_dereference_protected now?
Yes, in fact, lockdep ought to warn about this usage now, please enable
it :)
johannes
prev parent reply other threads:[~2014-03-10 20:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 11:19 [PATCH 1/3] mac80211: fix racy usage of chanctx->refcount Michal Kazior
2014-03-07 11:19 ` [PATCH 2/3] mac80211: include ieee80211_local in chanctx Michal Kazior
2014-03-10 20:27 ` Johannes Berg
2014-03-11 7:36 ` Michal Kazior
2014-03-07 11:19 ` [PATCH 3/3] mac80211: compute chanctx refcount dynamically Michal Kazior
2014-03-07 14:44 ` Johannes Berg
2014-03-08 4:34 ` Zhao, Gang
2014-03-09 9:47 ` Eliad Peller
2014-03-09 15:15 ` Eliad Peller
2014-03-11 7:46 ` Michal Kazior
2014-03-11 13:16 ` Johannes Berg
2014-03-11 13:33 ` Michal Kazior
2014-03-19 14:05 ` Johannes Berg
2014-03-09 9:40 ` [PATCH 1/3] mac80211: fix racy usage of chanctx->refcount Eliad Peller
2014-03-10 20:29 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394483382.30155.2.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=eliad@wizery.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).