From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] mac80211: compute chanctx refcount dynamically
Date: Tue, 11 Mar 2014 15:16:10 +0200 [thread overview]
Message-ID: <1394543770.30155.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQkke050EMs0Nnz3O3XM6U2uRRVrxffVdwKJrWua+iapFw@mail.gmail.com> (sfid-20140311_084612_507774_354C0D0C)
On Tue, 2014-03-11 at 08:46 +0100, Michal Kazior wrote:
> Self-NACK.
Heh.
> I totally missed how ieee80211_remove_interfaces() works. It removes
> all interfaces from the list in one go before each is actually
> stopped. This means refcount computes 0. IOW If you unload a driver
> with multiple interfaces running you get a nice general protection
> fault (multiple ieee80211_free_chanctx calls).
Ok, that seems like a problem :)
> I'm planning on adding `struct list_head` to sdata and chanctx to be
> able to iterate over assigned (and reserved, in the future) chanctx.
> What do you think? Do you have other ideas?
I guess that seems reasonable - not sure why you'd want the reserved
one? Some of the maintenance there might be tricky?
johannes
next prev parent reply other threads:[~2014-03-11 13:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 11:19 [PATCH 1/3] mac80211: fix racy usage of chanctx->refcount Michal Kazior
2014-03-07 11:19 ` [PATCH 2/3] mac80211: include ieee80211_local in chanctx Michal Kazior
2014-03-10 20:27 ` Johannes Berg
2014-03-11 7:36 ` Michal Kazior
2014-03-07 11:19 ` [PATCH 3/3] mac80211: compute chanctx refcount dynamically Michal Kazior
2014-03-07 14:44 ` Johannes Berg
2014-03-08 4:34 ` Zhao, Gang
2014-03-09 9:47 ` Eliad Peller
2014-03-09 15:15 ` Eliad Peller
2014-03-11 7:46 ` Michal Kazior
2014-03-11 13:16 ` Johannes Berg [this message]
2014-03-11 13:33 ` Michal Kazior
2014-03-19 14:05 ` Johannes Berg
2014-03-09 9:40 ` [PATCH 1/3] mac80211: fix racy usage of chanctx->refcount Eliad Peller
2014-03-10 20:29 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394543770.30155.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).