Re: [PATCH 1/4] mac80211: fix CSA tx queue locking

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2014-03-11 at 08:20 +0100, Michal Kazior wrote:

> > I don't like this function, even if technically stop is idempotent, it
> > still seems strange to call this "recalc".

> I wanted to make the stop/wake code decision in one place. I
> understand you prefer to have:
> 
>  if (can_wake)
>   wake()
> 
> and
> 
>  if (!can_wake)
>   stop()
> 
> calls explicitly instead of the "recalc" function?

Yes, I think that would be easier to understand? With the "recalc" you
have to understand that it's idempotent.

> >>       sdata->csa_chandef = params->chandef;
> >> +     sdata->csa_block_tx = params->block_tx;
> >
> > doesn't that more belong to the previous patch?
> 
> It belongs here.
> 
> CSA tx queue blocking is global. If you want to support multi- CSA
> then you need to keep queues blocked until last CSA that requires tx
> being blocked is completed. To do that you need to store which
> interface CSA requested block_tx.
> 
> I should probably include this note in the commit message.

Ok :)

johannes