Re: [PATCH v7 4/4] mac80211: allow reservation of a running chanctx

[Luca Coelho <luca@coelho.fi>]

On Wed, 2014-03-12 at 14:24 +0100, Michal Kazior wrote:
> On 12 March 2014 14:06, Luciano Coelho <luciano.coelho@intel.com> wrote:
> 
> [...]
> 
> > @@ -700,12 +735,7 @@ int ieee80211_vif_use_reserved_context(struct ieee80211_sub_if_data *sdata,
> >
> >         old_ctx = container_of(conf, struct ieee80211_chanctx, conf);
> >
> > -       if (sdata->vif.bss_conf.chandef.width != sdata->reserved_chandef.width)
> > -               tmp_changed |= BSS_CHANGED_BANDWIDTH;
> > -
> > -       sdata->vif.bss_conf.chandef = sdata->reserved_chandef;
> > -
> > -       /* unref our reservation before assigning */
> > +       /* unref our reservation */
> >         ctx->refcount--;
> >         sdata->reserved_chanctx = NULL;
> >
> > @@ -742,11 +772,6 @@ int ieee80211_vif_use_reserved_context(struct ieee80211_sub_if_data *sdata,
> >         }
> >
> >         *changed = tmp_changed;
> > -
> > -       ieee80211_recalc_chanctx_chantype(local, ctx);
> > -       ieee80211_recalc_smps_chanctx(local, ctx);
> > -       ieee80211_recalc_radar_chanctx(local, ctx);
> > -       ieee80211_recalc_chanctx_min_def(local, ctx);
> >  out:
> >         mutex_unlock(&local->chanctx_mtx);
> >         return ret;
> 
> I think you need these for if(old_ctx==new_ctx) case, don't you?

Rebase screw-ups ad-infinitum...

--
Luca.