From: Dan Williams <dcbw@redhat.com>
To: fariyaf@gmail.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4 00/11] rsi: Adding RS9113 wireless driver.
Date: Fri, 14 Mar 2014 14:04:51 -0500 [thread overview]
Message-ID: <1394823891.5829.14.camel@dcbw.local> (raw)
In-Reply-To: <1394465199-10042-1-git-send-email-fariyaf@gmail.com>
On Mon, 2014-03-10 at 20:56 +0530, fariyaf@gmail.com wrote:
> From: Fariya Fatima <fariyaf@gmail.com>
>
> This series of patches adds Redpine Signals wireless driver.
Looking much better, good work.
One last comment; there are a couple functions (rsi_device_init,
rsi_host_intf_write_pkt) that are defined multiple times, once in the
USB code and once in the SDIO code. These need to be renamed, otherwise
you will not be able to load the USB and the SDIO modules at the same
time.
I would suggest making all the functions in rsi_usb.h start with
"rsi_usb" if they don't already, and have functions in rsi_sdio.h start
with "rsi_sdio" if they don't already.
Dan
> Fariya Fatima (11):
> Adding RS9113 driver header files
> Adding remaining header files
> Adding core and main files.
> Writing packets to device and debugfs.
> MAC80211 callbacks to driver.
> MAC80211 callbacks and management functions internal to device.
> Management functions internal to the device.
> USB functionality
> SDIO functionality.
> Remaining SDIO functionality.
> Makefile and Kconfig
>
> drivers/net/wireless/Kconfig | 1 +
> drivers/net/wireless/Makefile | 1 +
> drivers/net/wireless/rsi/Kconfig | 30 +
> drivers/net/wireless/rsi/Makefile | 12 +
> drivers/net/wireless/rsi/rsi_91x_core.c | 342 +++++++
> drivers/net/wireless/rsi/rsi_91x_debugfs.c | 339 +++++++
> drivers/net/wireless/rsi/rsi_91x_mac80211.c | 1008 +++++++++++++++++++++
> drivers/net/wireless/rsi/rsi_91x_main.c | 270 ++++++
> drivers/net/wireless/rsi/rsi_91x_mgmt.c | 1302 +++++++++++++++++++++++++++
> drivers/net/wireless/rsi/rsi_91x_pkt.c | 195 ++++
> drivers/net/wireless/rsi/rsi_91x_sdio.c | 845 +++++++++++++++++
> drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 566 ++++++++++++
> drivers/net/wireless/rsi/rsi_91x_usb.c | 572 ++++++++++++
> drivers/net/wireless/rsi/rsi_91x_usb_ops.c | 177 ++++
> drivers/net/wireless/rsi/rsi_boot_params.h | 126 +++
> drivers/net/wireless/rsi/rsi_common.h | 87 ++
> drivers/net/wireless/rsi/rsi_debugfs.h | 48 +
> drivers/net/wireless/rsi/rsi_main.h | 232 +++++
> drivers/net/wireless/rsi/rsi_mgmt.h | 285 ++++++
> drivers/net/wireless/rsi/rsi_sdio.h | 129 +++
> drivers/net/wireless/rsi/rsi_usb.h | 70 ++
> 21 files changed, 6637 insertions(+), 0 deletions(-)
> create mode 100644 drivers/net/wireless/rsi/Kconfig
> create mode 100644 drivers/net/wireless/rsi/Makefile
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_core.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_debugfs.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_mac80211.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_main.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_mgmt.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_pkt.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_sdio.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_sdio_ops.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_usb.c
> create mode 100644 drivers/net/wireless/rsi/rsi_91x_usb_ops.c
> create mode 100644 drivers/net/wireless/rsi/rsi_boot_params.h
> create mode 100644 drivers/net/wireless/rsi/rsi_common.h
> create mode 100644 drivers/net/wireless/rsi/rsi_debugfs.h
> create mode 100644 drivers/net/wireless/rsi/rsi_main.h
> create mode 100644 drivers/net/wireless/rsi/rsi_mgmt.h
> create mode 100644 drivers/net/wireless/rsi/rsi_sdio.h
> create mode 100644 drivers/net/wireless/rsi/rsi_usb.h
>
next prev parent reply other threads:[~2014-03-14 19:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 15:26 [PATCH v4 00/11] rsi: Adding RS9113 wireless driver fariyaf
2014-03-10 15:26 ` [PATCH v4 01/11] rsi: Adding RS9113 driver header files fariyaf
2014-03-10 15:26 ` [PATCH v4 02/11] rsi: Adding remaining " fariyaf
2014-03-10 15:26 ` [PATCH v4 03/11] rsi: Adding core and main files fariyaf
2014-03-10 15:26 ` [PATCH v4 04/11] rsi: Writing packets to device and debugfs fariyaf
2014-03-10 15:26 ` [PATCH v4 05/11] rsi: MAC80211 callbacks to driver fariyaf
2014-03-10 15:26 ` [PATCH v4 06/11] rsi: MAC80211 callbacks and management functions internal to device fariyaf
2014-03-10 15:26 ` [PATCH v4 07/11] rsi: Management functions internal to the device fariyaf
2014-03-10 15:26 ` [PATCH v4 08/11] rsi: USB functionality fariyaf
2014-03-10 15:26 ` [PATCH v4 09/11] rsi: SDIO functionality fariyaf
2014-03-10 15:26 ` [PATCH v4 10/11] rsi: Remaining " fariyaf
2014-03-10 15:26 ` [PATCH v4 11/11] rsi: Makefile and Kconfig fariyaf
2014-03-14 19:04 ` Dan Williams [this message]
2014-03-14 19:26 ` [PATCH v4 00/11] rsi: Adding RS9113 wireless driver John W. Linville
2014-03-14 19:23 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394823891.5829.14.camel@dcbw.local \
--to=dcbw@redhat.com \
--cc=fariyaf@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).