From: Joe Perches <joe@perches.com>
To: Fariya Fatima <fariyaf@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 01/11] rsi: Adding RS9113 header files.
Date: Sat, 15 Mar 2014 15:23:50 -0700 [thread overview]
Message-ID: <1394922230.5689.2.camel@joe-AO722> (raw)
In-Reply-To: <1394921832-4056-2-git-send-email-fariyaf@gmail.com>
> diff --git a/drivers/net/wireless/rsi/rsi_main.h b/drivers/net/wireless/rsi/rsi_main.h
[]
> +static inline void rsi_dbg(u32 zone, const char *fmt, ...)
> +{
> + struct va_format vaf;
> + va_list args;
> +
> + va_start(args, fmt);
> +
> + vaf.fmt = fmt;
> + vaf.va = &args;
> +
> + if (zone & rsi_zone_enabled)
> + pr_info("%pV", &vaf);
> + va_end(args);
> +}
I believe debugging messages should be emitted at KERN_DEBUG.
Also, it seems that every use uses "%s: ", __func__.
I think it'd be better to remove all those uses from the
calling sites and use:
%pS:, __builtin_return_address(0)
next prev parent reply other threads:[~2014-03-15 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 22:17 [PATCH v5 00/11] rsi: Adding RS9113 wireless driver Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 01/11] rsi: Adding RS9113 header files Fariya Fatima
2014-03-15 22:23 ` Joe Perches [this message]
[not found] ` <CAG+h2qhwa-C4DC65ebV=s9tDEg-40QzS5604VBmMU3GhwkY07w@mail.gmail.com>
2014-03-16 7:09 ` Joe Perches
2014-03-15 22:17 ` [PATCH v5 02/11] rsi: Adding remaining " Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 03/11] rsi: Adding core and main files Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 04/11] rsi: Writing packets to device and debugfs Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 05/11] rsi: Adding MAC80211 callbacks to the driver Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 06/11] rsi: MAC80211 callbacks and management functions internal to device Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 07/11] rsi: Management functions internal to the device Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 08/11] rsi: Adding USB functionality Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 09/11] rsi: Adding SDIO functionality Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 10/11] rsi: Adding remaining " Fariya Fatima
2014-03-15 22:17 ` [PATCH v5 11/11] rsi: Adding Makefile and Kconfig Fariya Fatima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394922230.5689.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=fariyaf@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox