From: Luca Coelho <luca@coelho.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH v2] mac80211: verify deauthentication and return error on failure
Date: Wed, 19 Mar 2014 10:35:06 +0200 [thread overview]
Message-ID: <1395218106.2854.0.camel@dubbel> (raw)
In-Reply-To: <1395217729-13565-1-git-send-email-johannes@sipsolutions.net>
On Wed, 2014-03-19 at 09:28 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When still authenticating the mac80211 code handling a deauthentication
> requests from userspace doesn't verify that the request is valid in any
> way, fix that. Additionally, it never returns an error, even if there's
> no connection or authentication attempt, fix that as well.
>
> While at it, move the message to not print a message in the error case
> and to distinguish between the two cases.
>
> Also simplify the code by duplicating the cfg80211 call.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
Reviewed-by: Luciano Coelho <luciano.coelho@intel.com>
prev parent reply other threads:[~2014-03-19 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 8:28 [PATCH v2] mac80211: verify deauthentication and return error on failure Johannes Berg
2014-03-19 8:35 ` Luca Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395218106.2854.0.camel@dubbel \
--to=luca@coelho.fi \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).