From: Johannes Berg <johannes@sipsolutions.net>
To: Rostislav Lisovy <lisovy@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Sojka <sojkam1@fel.cvut.cz>,
s.sander@nordsys.de, jan-niklas.meier@volkswagen.de,
Rostislav Lisovy <rostislav.lisovy@fel.cvut.cz>
Subject: Re: [PATCH 0/5] cfg80211: Add channel attributes to be used with 5/10MHz channels
Date: Fri, 28 Mar 2014 09:50:24 +0100 [thread overview]
Message-ID: <1395996624.4175.8.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1394543114-6700-1-git-send-email-rostislav.lisovy@fel.cvut.cz> (sfid-20140311_140522_704622_0C67DCB5)
On Tue, 2014-03-11 at 14:05 +0100, Rostislav Lisovy wrote:
> The IEEE 802.11p amendment specifies usage of 5 and 10 MHz wide
> channels in 5.9GHz band for vehicular environment. This patch-set adds
> new channel attributes holding the information about the prohibited
> bandwidths. This is meant to be used mainly with channels in 5.9GHz
> band in future implementation of 802.11p.
This looks fine, but you need to rebase. Also, maybe squash patches 1/2
or something, the patches are pretty oddly split up IMHO, with nl80211.h
updates in one patch and the nl80211.c in the other, for example.
It'd also be good to have some text in the empty commit logs of patches
3 and 5.
johannes
next prev parent reply other threads:[~2014-03-28 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 13:05 [PATCH 0/5] cfg80211: Add channel attributes to be used with 5/10MHz channels Rostislav Lisovy
2014-03-11 13:05 ` [PATCH 1/5] cfg80211: Add attributes describing prohibited channel bandwidth Rostislav Lisovy
2014-03-11 13:05 ` [PATCH 2/5] nl80211: Support for 5/10 MHz channels when reporting BW restrictions Rostislav Lisovy
2014-03-11 13:05 ` [PATCH 3/5] cfg80211: Take the BW restrictions into account when checking the channel Rostislav Lisovy
2014-03-11 13:05 ` [PATCH 4/5] cfg80211: Use 5MHz bandwidth by default when checking usable channels Rostislav Lisovy
2014-03-11 13:05 ` [PATCH 5/5] mac80211: Update conf_is_ht() to work properly with 5/10MHz channels Rostislav Lisovy
2014-03-28 8:50 ` Johannes Berg [this message]
2014-04-02 13:34 ` [PATCH 0/5] cfg80211: Add channel attributes to be used " Rostislav Lisovy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395996624.4175.8.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jan-niklas.meier@volkswagen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lisovy@gmail.com \
--cc=rostislav.lisovy@fel.cvut.cz \
--cc=s.sander@nordsys.de \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox