linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Zhao, Gang" <gamerh2o@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/8] mac80211: fix possible compile warning in michael.h
Date: Wed, 09 Apr 2014 14:47:31 +0200	[thread overview]
Message-ID: <1397047651.4964.15.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <0c2fa5b7a8724d0ee405afd05f393af95e65116c.1397006688.git.gamerh2o@gmail.com> (sfid-20140409_032855_945110_A8572F5D)

On Wed, 2014-04-09 at 09:28 +0800, Zhao, Gang wrote:
> The warning doesn't show up due to duplicate including, but it's worth
> fixing it.
> 
> net/mac80211//michael.h:22:4: warning: ‘struct ieee80211_hdr’ declared inside parameter list [enabled by default]
>     const u8 *data, size_t data_len, u8 *mic);
>     ^
> net/mac80211//michael.h:22:4: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> 
> Signed-off-by: Zhao, Gang <gamerh2o@gmail.com>
> ---
>  net/mac80211/michael.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/michael.h b/net/mac80211/michael.h
> index 3b848da..b259547 100644
> --- a/net/mac80211/michael.h
> +++ b/net/mac80211/michael.h
> @@ -10,7 +10,7 @@
>  #ifndef MICHAEL_H
>  #define MICHAEL_H
>  
> -#include <linux/types.h>
> +#include <linux/ieee80211.h>

This should probably include both now though.

johannes


  reply	other threads:[~2014-04-09 12:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09  1:28 [PATCH 1/8] cfg80211: fix possible compile warning in wext-compat.h Zhao, Gang
2014-04-09  1:28 ` [PATCH 2/8] mac80211: fix possible compile warning in debugfs.h Zhao, Gang
2014-04-09  1:28 ` [PATCH 3/8] mac80211: fix possible compile warning in michael.h Zhao, Gang
2014-04-09 12:47   ` Johannes Berg [this message]
2014-04-09  1:28 ` [PATCH 4/8] mac80211: fix possible compile warning in debugfs_netdev.h Zhao, Gang
2014-04-09 12:50   ` Johannes Berg
2014-04-09  1:28 ` [PATCH 5/8] cfg80211: remove unnecessary include clauses (cfg80211.h) Zhao, Gang
2014-04-09  1:28 ` [PATCH 6/8] mac80211: remove unnecessary include clauses (mac80211.h) Zhao, Gang
2014-04-09  1:28 ` [PATCH 7/8] mac80211: remove unnecessary include clauses Zhao, Gang
2014-04-09  1:28 ` [PATCH 8/8] cfg80211: " Zhao, Gang
2014-04-09  7:49   ` Johannes Berg
2014-04-09 12:25     ` Zhao, Gang
2014-04-09 12:36       ` Johannes Berg
2014-04-09 12:43         ` Johannes Berg
2014-04-10  2:37           ` Zhao, Gang
2014-04-09 15:22         ` Zhao, Gang
2014-04-09 13:49     ` Zhao, Gang
2014-04-09 12:46 ` [PATCH 1/8] cfg80211: fix possible compile warning in wext-compat.h Johannes Berg
2014-04-09 14:18   ` Zhao, Gang
2014-04-10  8:02     ` Johannes Berg
2014-04-10  8:09 ` Johannes Berg
2014-04-11  0:27   ` Zhao, Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397047651.4964.15.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=gamerh2o@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).