From: Johannes Berg <johannes@sipsolutions.net>
To: Arik Nemtsov <arik@wizery.com>
Cc: Colleen T <colleen@cozybit.com>,
"Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Janusz Dziedzic <janusz.dziedzic@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Sander Eikelenboom <linux@eikelenboom.it>
Subject: Re: [PATCH 2/3] cfg80211: fix processing world regdomain when non modular
Date: Thu, 10 Apr 2014 10:01:42 +0200 [thread overview]
Message-ID: <1397116902.4757.6.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+XVXfdekoT_jhVL_vpjJSPPD5hAjyprUB+g4kAN2Nssv=9-Ng@mail.gmail.com> (sfid-20140410_081344_153851_6493AFAD)
On Thu, 2014-04-10 at 09:13 +0300, Arik Nemtsov wrote:
> On Wed, Apr 9, 2014 at 10:16 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > +static void reg_free_last_request(struct regulatory_request *lr)
> >
> > Isn't it odd to pass the last request to a function called
> > reg_free_last_request()?
> >
>
> It makes sense to me. Non-last requests are freed using kfree. The
> last request needs RCU.
Yeah but there can only be one "last request", so why pass it?
johannes
next prev parent reply other threads:[~2014-04-10 8:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 1:09 [PATCH v2 0/3] cfg80211: respin reprocessing pending requests Luis R. Rodriguez
2014-02-26 1:09 ` [PATCH 1/3] cfg80211: allow reprocessing of " Luis R. Rodriguez
2014-03-03 13:10 ` Johannes Berg
2014-02-26 1:09 ` [PATCH 2/3] cfg80211: fix processing world regdomain when non modular Luis R. Rodriguez
2014-03-03 13:10 ` Johannes Berg
2014-03-14 20:30 ` Colleen T
2014-03-14 20:48 ` Luis R. Rodriguez
2014-03-14 22:12 ` Colleen T
2014-03-15 1:03 ` Luis R. Rodriguez
2014-03-15 15:59 ` Janusz Dziedzic
2014-03-16 4:42 ` Luis R. Rodriguez
2014-03-16 19:04 ` Colleen T
2014-04-09 16:33 ` Arik Nemtsov
2014-04-09 19:16 ` Johannes Berg
2014-04-10 6:13 ` Arik Nemtsov
2014-04-10 8:01 ` Johannes Berg [this message]
2014-04-10 8:17 ` Arik Nemtsov
2014-04-10 8:23 ` Johannes Berg
2014-04-09 20:28 ` Sander Eikelenboom
2014-04-13 12:50 ` Eliad Peller
2014-04-14 19:27 ` Colleen T
2014-04-16 10:38 ` Arik Nemtsov
2014-04-16 11:01 ` Janusz Dziedzic
2014-04-16 11:07 ` Arik Nemtsov
2014-03-19 14:01 ` Johannes Berg
2014-02-26 1:09 ` [PATCH 3/3] cfg80211: processing regulatory requests on netdev notifier Luis R. Rodriguez
2014-02-27 13:21 ` Arik Nemtsov
2014-02-27 17:20 ` Luis R. Rodriguez
2014-02-27 20:31 ` Arik Nemtsov
2014-02-26 7:41 ` [PATCH v2 0/3] cfg80211: respin reprocessing pending requests Sander Eikelenboom
-- strict thread matches above, loose matches on Subject: below --
2013-12-19 20:53 [PATCH 0/3] cfg80211: process pending regulatory requests Luis R. Rodriguez
2013-12-19 20:53 ` [PATCH 2/3] cfg80211: fix processing world regdomain when non modular Luis R. Rodriguez
2014-01-07 15:35 ` Johannes Berg
2014-02-19 1:10 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397116902.4757.6.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arik@wizery.com \
--cc=colleen@cozybit.com \
--cc=janusz.dziedzic@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=mcgrof@do-not-panic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).