From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Jouni Malinen <jouni@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] mac80211: Support dynamic AP mode channel width changes
Date: Mon, 28 Apr 2014 17:46:22 +0200 [thread overview]
Message-ID: <1398699982.4132.1.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQ=gP49PDuyYovQmc-jtFwKN6JDOToSsT20ssnJZGaqieQ@mail.gmail.com> (sfid-20140428_105724_959492_6ACA3997)
On Mon, 2014-04-28 at 10:57 +0200, Michal Kazior wrote:
> > +static int ieee80211_set_ap_channel(struct wiphy *wiphy,
> > + struct net_device *dev,
> > + struct cfg80211_chan_def *chandef)
> > +{
> > + struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
> > + int ret;
> > + u32 changed = 0;
> > +
>
> Shouldn't interface combinations be verified here? What if there was a
> bandwidth upgrade (after a downgrade) but in the meantime a vif with a
> to-be incompatible chandef was brought up?
Yeah that seems like a potential issue.
> I think the existing usage
> of ieee80211_vif_change_bandwidth() in ieee80211_config_bw() already
> suffers from this problem or am I missing something?
That sounds like you're arguing it should be fixed in a separate patch
to ieee80211_vif_change_bandwidth()? :)
johannes
next prev parent reply other threads:[~2014-04-28 15:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 8:22 [PATCH 2/3] mac80211: Support dynamic AP mode channel width changes Jouni Malinen
2014-04-28 8:57 ` Michal Kazior
2014-04-28 15:46 ` Johannes Berg [this message]
2014-04-28 15:47 ` Johannes Berg
2014-04-29 6:00 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398699982.4132.1.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox