Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [bug report] wifi: mac80211: store BSS param change count from assoc response
Date: Thu, 22 Jun 2023 19:43:43 +0200	[thread overview]
Message-ID: <139908050c1c5941d791c228ef06fdfd55615d32.camel@sipsolutions.net> (raw)
In-Reply-To: <1c031edf-a2ab-4548-a181-16b8c641d786@moroto.mountain>

On Thu, 2023-06-22 at 17:47 +0300, Dan Carpenter wrote:
> 
>     4922         if (control & IEEE80211_MLE_STA_CONTROL_COMPLETE_PROFILE &&
>                                                                           ^^
> Should this be ||?
> 
>     4923             control & IEEE80211_MLE_STA_CONTROL_NSTR_BITMAP_SIZE) {
>     4924                 if (control & IEEE80211_MLE_STA_CONTROL_NSTR_BITMAP_SIZE)
> 
> This is always true because it's checked on the previous line.
> 

Oops. There are actually two places doing this, I think I copy/pasted
it.

But the second part of the if statement should simply be removed. The
COMPLETE_PROFILE bit indicates whether or not the NSTR bitmap is
present, and the NSTR_BITMAP_SIZE bit indicates how it's encoded (8 or
16 bits).

Thanks!

johannes

  reply	other threads:[~2023-06-22 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 14:47 [bug report] wifi: mac80211: store BSS param change count from assoc response Dan Carpenter
2023-06-22 17:43 ` Johannes Berg [this message]
2023-06-22 19:00   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=139908050c1c5941d791c228ef06fdfd55615d32.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox