From: Johannes Berg <johannes@sipsolutions.net>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Bing Zhao <bzhao@marvell.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Amitkumar Karwar <akarwar@marvell.com>,
Avinash Patil <patila@marvell.com>,
Maithili Hinge <maithili@marvell.com>,
Xinming Hu <huxm@marvell.com>
Subject: Re: [PATCH 2/5] mwifiex: add firmware dump feature for PCIe
Date: Mon, 05 May 2014 14:57:39 +0200 [thread overview]
Message-ID: <1399294659.22235.9.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <87y4ymn69s.fsf@qca.qualcomm.com>
On Wed, 2014-04-30 at 19:14 +0300, Kalle Valo wrote:
> >> We have it in iwlwifi as well - we were considering a generic uevent but
> >> beyond that I don't think there's much that could be done?
> >
> > There is an ethtool op for that, no?
>
> Do you mean this one:
>
> * @get_dump_flag: Get dump flag indicating current dump length, version,
> * and flag of the device.
> * @get_dump_data: Get dump data.
> * @set_dump: Set dump specific flags to the device.
>
> int (*get_dump_flag)(struct net_device *, struct ethtool_dump *);
> int (*get_dump_data)(struct net_device *,
> struct ethtool_dump *, void *);
> int (*set_dump)(struct net_device *, struct ethtool_dump *);
>
> Yeah, maybe we could use that in wireless as well.
What was the intended use case for this though? Neither the header file
nor the ethtool documentation seem particularly clear, other than saying
"firmware dump" - we'll want to include driver data as well though?
johannes
next prev parent reply other threads:[~2014-05-05 12:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 18:46 [PATCH 1/5] mwifiex: add fw_dump debugfs file Bing Zhao
2014-04-17 18:47 ` [PATCH 2/5] mwifiex: add firmware dump feature for PCIe Bing Zhao
2014-04-24 9:08 ` Kalle Valo
2014-04-25 1:37 ` John W. Linville
2014-04-25 3:35 ` Bing Zhao
2014-04-25 8:09 ` Johannes Berg
2014-04-30 7:41 ` Kalle Valo
2014-04-30 8:29 ` Johannes Berg
2014-04-30 13:22 ` John W. Linville
2014-04-30 16:14 ` Kalle Valo
2014-05-05 12:57 ` Johannes Berg [this message]
2014-05-05 14:19 ` Amitkumar Karwar
2014-05-05 15:04 ` Johannes Berg
2014-05-05 15:49 ` Amitkumar Karwar
2014-04-30 16:13 ` Kalle Valo
2014-05-05 12:58 ` Johannes Berg
2014-04-17 18:47 ` [PATCH 3/5] mwifiex: increase tx/rx AMPDU window sizes for STA 11n mode Bing Zhao
2014-04-17 18:47 ` [PATCH 4/5] mwifiex: increase tx/rx AMPDU window sizes for STA 11ac mode Bing Zhao
2014-04-17 18:47 ` [PATCH 5/5] mwifiex: enable aggregation for TID 6 and 7 streams Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399294659.22235.9.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=huxm@marvell.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=maithili@marvell.com \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).