From: Johannes Berg <johannes@sipsolutions.net>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
"John W. Linville" <linville@tuxdriver.com>,
Bing Zhao <bzhao@marvell.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Avinash Patil <patila@marvell.com>,
Maithili Hinge <maithili@marvell.com>,
Xinming Hu <huxm@marvell.com>,
Anirban Chakraborty <anirban.chakraborty@qlogic.com>,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH 2/5] mwifiex: add firmware dump feature for PCIe
Date: Mon, 05 May 2014 17:04:51 +0200 [thread overview]
Message-ID: <1399302291.22235.22.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <5FF020A1CFFEEC49BD1E09530C4FF59511A1FC9324@SC-VEXCH1.marvell.com>
On Mon, 2014-05-05 at 07:19 -0700, Amitkumar Karwar wrote:
> In mwifiex, we are interested in providing separate firmware dump file to user for each memory segment. Ex. ITCM, DTCM, SQRAM etc.
We have multiple things as well, firmware memory, last driver
commands, ...
> It looks simpler with ethtool ops instead of creating multiple debugfs files.
What we decided to do is encode the file with an IE-like structure so we
can extend the format in the future.
> 1) User can set index for required memory segment.
>
> #ethtool --set-dump wlan0 3
>
> 2) Get the details
>
> #ethtool --get-dump wlan0
> flag: 3, version:xyz, length:13450
>
> 3) Dump the info in ITCM.log file
>
> #ethtool --get-dump wlan0 data ITCM.log
This works, though I'd be worried about getting a consistent snapshot,
no?
> Common uevent through cfg80211 API to notify firmware dump is over would be useful for us.
That makes some sense.
The way our code works is that it stores all the desired data on an
error, triggers the event & restart, and then you can request the data
later.
I'm not sure ethtool dump is appropriate for that - it seems to be more
used for "get a dump right now during operation" type scenarios?
johannes
next prev parent reply other threads:[~2014-05-05 15:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 18:46 [PATCH 1/5] mwifiex: add fw_dump debugfs file Bing Zhao
2014-04-17 18:47 ` [PATCH 2/5] mwifiex: add firmware dump feature for PCIe Bing Zhao
2014-04-24 9:08 ` Kalle Valo
2014-04-25 1:37 ` John W. Linville
2014-04-25 3:35 ` Bing Zhao
2014-04-25 8:09 ` Johannes Berg
2014-04-30 7:41 ` Kalle Valo
2014-04-30 8:29 ` Johannes Berg
2014-04-30 13:22 ` John W. Linville
2014-04-30 16:14 ` Kalle Valo
2014-05-05 12:57 ` Johannes Berg
2014-05-05 14:19 ` Amitkumar Karwar
2014-05-05 15:04 ` Johannes Berg [this message]
2014-05-05 15:49 ` Amitkumar Karwar
2014-04-30 16:13 ` Kalle Valo
2014-05-05 12:58 ` Johannes Berg
2014-04-17 18:47 ` [PATCH 3/5] mwifiex: increase tx/rx AMPDU window sizes for STA 11n mode Bing Zhao
2014-04-17 18:47 ` [PATCH 4/5] mwifiex: increase tx/rx AMPDU window sizes for STA 11ac mode Bing Zhao
2014-04-17 18:47 ` [PATCH 5/5] mwifiex: enable aggregation for TID 6 and 7 streams Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399302291.22235.22.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=akarwar@marvell.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=ben@decadent.org.uk \
--cc=bzhao@marvell.com \
--cc=huxm@marvell.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=maithili@marvell.com \
--cc=patila@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).