Re: [PATCH 1/3] mac80211: move csa counters from sdata to beacon/presp

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2014-05-22 at 15:53 +0200, Michal Kazior wrote:

> >>  static int ieee80211_assign_beacon(struct ieee80211_sub_if_data *sdata,
> >> -                                struct cfg80211_beacon_data *params)
> >> +                                struct cfg80211_beacon_data *params,
> >> +                                const u16 *csa_counter_offset_beacon,
> >> +                                int n_csa_counter_offset_beacon,
> >> +                                const u16 *csa_counter_offset_presp,
> >> +                                int n_csa_counter_offset_presp,
> >> +                                u8 csa_count)
> >
> > But that seems overkill. Maybe those CSA-related arguments could be in
> > some new struct so you don't have to pass "..., NULL, 0, NULL, 0, 0"?
> 
> I didn't want to invent a structure just to pass a bunch of arguments.

I don't see any problem with that?

> Hmm.. maybe we can move counter offsets into cfg80211_beacon_data?
> This would apply to cfg80211_csa_settings as well.

I don't think that's a good idea, since the cfg80211_beacon_data is used
in places where that wouldn't make sense, that would confuse the API.
You could use "struct cfg80211_csa_settings" here I suppose, but I think
a new struct is perfectly reasonable.

johannes