From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>
Cc: Michal Kazior <michal.kazior@tieto.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: add a single-transaction driver op to switch contexts
Date: Fri, 23 May 2014 11:30:19 +0200 [thread overview]
Message-ID: <1400837419.4358.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1400836483.25946.37.camel@dubbel>
On Fri, 2014-05-23 at 12:14 +0300, Luca Coelho wrote:
> What do you mean mine doesn't support tracing? Check the bottom of the
> patch again. :) I don't think it's the most beautiful code, but it seems
> to work. :)
Oh, I was going by the old version I guess! :)
That tracing code looks OK to me, though I think that the vif name field
is too short?
> Also, my patch *does* support multiple vifs. But the code we have
> doesn't support it, so I call the new op with a single-vif only.
> Michal's patch doesn't call the new op (only on a later patch), so it's
> pretty much the same.
Right, ok. So it's a wash. Flip a coin? :)
johannes
next prev parent reply other threads:[~2014-05-23 9:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 14:07 [PATCH v6 0/6] cfg/mac80211: implement multi-vif csa Michal Kazior
2014-05-22 14:07 ` [PATCH v6 1/6] mac80211: introduce switch_vif_chanctx op Michal Kazior
2014-05-22 14:45 ` Johannes Berg
2014-05-23 2:38 ` [PATCH] mac80211: add a single-transaction driver op to switch contexts Luca Coelho
2014-05-23 2:49 ` Luca Coelho
2014-05-23 7:51 ` Michal Kazior
2014-05-23 8:01 ` Michal Kazior
2014-05-23 8:58 ` Johannes Berg
2014-05-23 9:14 ` Luca Coelho
2014-05-23 9:30 ` Johannes Berg [this message]
2014-05-23 9:52 ` Johannes Berg
2014-05-23 11:33 ` [PATCH 1/2] " Luca Coelho
2014-05-23 11:33 ` [PATCH 2/2] mac80211: use switch_vif_chanctx to change a running chanctx Luca Coelho
2014-05-23 11:35 ` Luca Coelho
2014-05-23 13:28 ` Johannes Berg
2014-05-23 13:31 ` Luca Coelho
2014-05-23 13:24 ` [PATCH 1/2] mac80211: add a single-transaction driver op to switch contexts Johannes Berg
2014-05-23 13:30 ` Luca Coelho
2014-05-23 9:16 ` [PATCH] " Michal Kazior
2014-05-23 9:26 ` Johannes Berg
2014-05-23 6:09 ` [PATCH v6 1/6] mac80211: introduce switch_vif_chanctx op Michal Kazior
2014-05-23 8:51 ` Johannes Berg
2014-05-23 9:10 ` Michal Kazior
2014-05-23 9:31 ` Johannes Berg
2014-05-22 14:07 ` [PATCH v6 2/6] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-05-22 14:51 ` Johannes Berg
2014-05-23 6:16 ` Michal Kazior
2014-05-23 12:23 ` Michal Kazior
2014-05-23 13:14 ` Johannes Berg
2014-05-22 14:07 ` [PATCH v6 3/6] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-05-22 14:07 ` [PATCH v6 4/6] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-05-22 14:54 ` Johannes Berg
2014-05-23 6:49 ` Michal Kazior
2014-05-23 8:44 ` Johannes Berg
2014-05-23 8:58 ` Michal Kazior
2014-05-23 9:07 ` Johannes Berg
2014-05-23 9:35 ` Michal Kazior
2014-05-23 9:53 ` Johannes Berg
2014-05-22 14:07 ` [PATCH v6 5/6] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-05-22 14:07 ` [PATCH v6 6/6] cfg80211: remove channel_switch combination check Michal Kazior
2014-05-22 14:57 ` Johannes Berg
2014-05-23 7:04 ` Michal Kazior
2014-05-23 8:53 ` Johannes Berg
2014-05-23 9:11 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400837419.4358.17.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).