Re: [PATCH 1/2] mac80211: add a single-transaction driver op to switch contexts

[Luca Coelho <luca@coelho.fi>]

On Fri, 2014-05-23 at 15:24 +0200, Johannes Berg wrote:
> On Fri, 2014-05-23 at 14:33 +0300, Luca Coelho wrote:
> > From: Luciano Coelho <luciano.coelho@intel.com>
> > 
> > In some cases, when the driver is already using all the channel
> > contexts it can handle at once, we have to do an in-place switch
> > (ie. we cannot afford using an extra context temporarily for the
> > transaction).  But some drivers may not support switching the channel
> > context assigned to a vif on the fly (ie. without unassigning and
> > assigning it) while others may only work if the context is changed on
> > the fly, without unassigning it first.
> > 
> > To allow these different scenarios, add a new driver operation that
> > let's the driver decide how to handle an in-place switch.
> 
> Ok, I've applied this. I extended the warning for the new context (to
> check that it exists in the reassign case) and changed the tracing
> structs slightly (fixing the ifname length and marking the structs
> packed to avoid alignment issues)

Great, thanks!

I was just adding the __packed in the struct, because I am implementing
the parser for trace-cmd and noticed we could have trouble. :)

--
Luca.