From: Joe Perches <joe@perches.com>
To: Jahnavi Meher <jahnavi.meher@redpinesignals.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] rsi: Adding support for bgscan, 5GHz support and clean up of code
Date: Mon, 02 Jun 2014 09:28:25 -0700 [thread overview]
Message-ID: <1401726505.5770.2.camel@joe-AO725> (raw)
In-Reply-To: <538C910E.6090703@redpinesignals.com>
On Mon, 2014-06-02 at 20:28 +0530, Jahnavi Meher wrote:
> This patch adds code for support of bgscan and 5GHz.
[]
> There are also a number of small clean ups.
[]
> diff -uprN b/drivers/net/wireless/rsi/rsi_91x_mac80211.c a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
[]
> @@ -243,8 +243,8 @@ static void rsi_mac80211_tx(struct ieee8
> {
> struct rsi_hw *adapter = hw->priv;
> struct rsi_common *common = adapter->priv;
> -
> rsi_core_xmit(common, skb);
> + return;
> }
Adding unnecessary returns at the end of a void function
is not an improvement.
next prev parent reply other threads:[~2014-06-02 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:58 [PATCH 1/1] rsi: Adding support for bgscan, 5GHz support and clean up of code Jahnavi Meher
2014-06-02 16:28 ` Joe Perches [this message]
2014-06-03 10:52 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401726505.5770.2.camel@joe-AO725 \
--to=joe@perches.com \
--cc=jahnavi.meher@redpinesignals.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox