From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Luca Coelho <luca@coelho.fi>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v7 1/5] mac80211: implement multi-vif in-place reservations
Date: Wed, 04 Jun 2014 14:38:13 +0200 [thread overview]
Message-ID: <1401885493.6079.22.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CA+BoTQn=rpLqg4AU9Q6jXSo3D1os76B7bFhnqPyk=47QX5T1SQ@mail.gmail.com> (sfid-20140604_141223_261913_438F9888)
On Wed, 2014-06-04 at 14:12 +0200, Michal Kazior wrote:
> >> >> + if (!(old_ctx->replaced_by && new_ctx->replaces)) {
> >> >
> >> > Isn't !old->ctx->replaced_by enough here? Do you really care if the
> >> > new_ctx will replace something else at this point?
> >>
> >> Hmm..
> >>
> >> Now that I think this should actually be just:
> >>
> >> if (!new_ctx->replaces) { ... }
> >
> > Oh ... I think that's what I asked above. Nah. This check actually means
> > that it *is* possible that replaced_by and replaces are true at the same
> > time? *confused*
>
> If you refer to the original condition do note the *old_ctx* and *new_ctx*.
>
> As I stated above for a single channel context both `replaces` and
> `replaced_by` shouldn't be set at the same time.
Ah, right, I did mix that up, thanks for the clarification.
johannes
next prev parent reply other threads:[~2014-06-04 12:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 7:34 [PATCH v7 0/5] cfg/mac80211: implement multi-vif csa Michal Kazior
2014-05-29 7:34 ` [PATCH v7 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-02 11:33 ` Luca Coelho
2014-06-03 6:15 ` Michal Kazior
2014-06-03 17:10 ` Johannes Berg
2014-06-04 12:12 ` Michal Kazior
2014-06-04 12:38 ` Johannes Berg [this message]
2014-05-29 7:34 ` [PATCH v7 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-05-29 7:34 ` [PATCH v7 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-03 19:49 ` Johannes Berg
2014-05-29 7:34 ` [PATCH v7 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-05-29 7:34 ` [PATCH v7 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-03 19:51 ` [PATCH v7 0/5] cfg/mac80211: implement multi-vif csa Johannes Berg
2014-06-05 12:56 ` [PATCH v8 " Michal Kazior
2014-06-05 12:56 ` [PATCH v8 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-09 16:27 ` Eliad Peller
2014-06-10 5:16 ` Michal Kazior
2014-06-05 12:56 ` [PATCH v8 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-06-05 12:56 ` [PATCH v8 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-05 12:56 ` [PATCH v8 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-06-05 12:56 ` [PATCH v8 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-12 12:54 ` [PATCH v9 0/5] cfg/mac80211: implement multi-vif csa Michal Kazior
2014-06-12 12:54 ` [PATCH v9 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-16 14:35 ` Luca Coelho
2014-06-17 5:52 ` Michal Kazior
2014-06-12 12:54 ` [PATCH v9 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-06-12 12:54 ` [PATCH v9 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-12 12:54 ` [PATCH v9 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-06-12 12:54 ` [PATCH v9 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-17 12:58 ` [PATCH v10 0/5] cfg/mac80211: implement multi-vif csa Michal Kazior
2014-06-17 12:58 ` [PATCH v10 1/5] mac80211: implement multi-vif in-place reservations Michal Kazior
2014-06-23 13:03 ` Johannes Berg
2014-06-24 11:55 ` Michal Kazior
2014-06-24 11:59 ` Johannes Berg
2014-06-17 12:58 ` [PATCH v10 2/5] mac80211: make check_combinations() aware of chanctx reservation Michal Kazior
2014-06-17 12:58 ` [PATCH v10 3/5] mac80211: use chanctx reservation for AP CSA Michal Kazior
2014-06-17 12:58 ` [PATCH v10 4/5] mac80211: use chanctx reservation for STA CSA Michal Kazior
2014-06-17 12:58 ` [PATCH v10 5/5] cfg80211: remove channel_switch combination check Michal Kazior
2014-06-23 10:46 ` [PATCH v10 0/5] cfg/mac80211: implement multi-vif csa Luca Coelho
2014-06-23 13:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401885493.6079.22.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).