From: Johannes Berg <johannes@sipsolutions.net>
To: andrea.merello@gmail.com
Cc: emmanuel.grumbach@intel.com,
Linux Wireless List <linux-wireless@vger.kernel.org>,
joerg.albert@gmx.de, Alex Stewart <alex@foogod.com>,
n0_5p4m_p13453@hotmail.com, Pavel Roskin <proski@gnu.org>,
agx@sigxcpu.org, Kalle Valo <kalle.valo@iki.fi>,
sesmo@gmx.net, John Linville <linville@tuxdriver.com>
Subject: Re: [RFC] mac80211: at76x50x_usb driver broken by commit 3afc216.. and RX path involved in scan
Date: Thu, 05 Jun 2014 14:32:56 +0200 [thread overview]
Message-ID: <1401971576.4168.3.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <CAN8YU5NVmAMQ06oJ2Urze7=m4XNUox4-QmYbE1ozoRTFOEY0=g@mail.gmail.com> (sfid-20140604_230243_516417_A2A8F6A0)
> So this is the updated patch.
> If you agree, we could push it for merge :)
Yeah, looks fine. Minor code style comments below:
> +static inline int at76_guess_freq(struct at76_priv *priv)
> +{
> + size_t el_off;
should have tabs for indentation
> + const u8 *el;
> + int channel = priv->channel;
> + int len = priv->rx_skb->len;
> + struct ieee80211_hdr *hdr = (void *)priv->rx_skb->data;
> +
> + if (!priv->scanning)
> + goto exit;
> +
> + if (len < 24)
> + goto exit;
> +
> + if (ieee80211_is_probe_resp(hdr->frame_control)) {
> + el_off = offsetof(struct ieee80211_mgmt, u.probe_resp.variable);
> + el = ((struct ieee80211_mgmt *)hdr)->u.probe_resp.variable;
> + } else if (ieee80211_is_beacon(hdr->frame_control)) {
> + el_off = offsetof(struct ieee80211_mgmt, u.beacon.variable);
> + el = ((struct ieee80211_mgmt *)hdr)->u.beacon.variable;
> + } else
> + goto exit;
should have braces around all branches
johannes
next prev parent reply other threads:[~2014-06-05 12:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 15:42 [RFC] mac80211: at76x50x_usb driver broken by commit 3afc216.. and RX path involved in scan Andrea Merello
2014-05-18 7:10 ` Grumbach, Emmanuel
2014-05-19 14:29 ` Johannes Berg
2014-05-19 14:49 ` Johannes Berg
2014-05-19 15:42 ` Andrea Merello
2014-05-19 16:02 ` Johannes Berg
2014-05-19 16:05 ` Andrea Merello
2014-05-26 11:53 ` Andrea Merello
2014-05-28 14:02 ` Johannes Berg
2014-05-31 18:54 ` Andrea Merello
2014-06-03 19:57 ` Johannes Berg
2014-06-04 21:02 ` Andrea Merello
2014-06-05 12:32 ` Johannes Berg [this message]
2014-06-05 14:10 ` [PATCH] at76c50x: fix scan does not work with latest mac80211 Andrea Merello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401971576.4168.3.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=agx@sigxcpu.org \
--cc=alex@foogod.com \
--cc=andrea.merello@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=joerg.albert@gmx.de \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=n0_5p4m_p13453@hotmail.com \
--cc=proski@gnu.org \
--cc=sesmo@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox